Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Path Traversal Vulnerability #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions home/frontend/views.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from flask import render_template, flash, redirect, send_file, url_for, jsonify
from flask import render_template, flash, redirect, send_file, url_for, jsonify, safe_join
from home import app, redis_store, twilio
from home.frontend import frontend

Expand Down Expand Up @@ -74,5 +74,6 @@ def get_resume():

@frontend.route('/download/<path:filename>')
def download(filename):
flash("Downloading " + '/'.join(['static','download', filename]))
return send_file('/'.join(['static','download', filename]))
path = safe_join('static','download', filename)
flash("Downloading " + path)
return send_file(path)