Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically sign visual style if 'packthem.exe' is in the current directory #92

Open
gdl-blue opened this issue Aug 15, 2022 · 4 comments

Comments

@gdl-blue
Copy link

gdl-blue commented Aug 15, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-> I need to patch uxtheme.dll, or sign the msstyle file to apply it.

Describe the solution you'd like
A clear and concise description of what you want to happen.
-> packthem.exe is a program from Microsoft that can compile msstyles for XP, and can sign msstyles for XP/Vista/7. (It does not work for Windows 10 so exclude it)
so, if the user puts packthem.exe to the current directory, and if msstyleEditor detects that program in the current directory, run packthem -s xxx.msstyles(-s means sign the msstyle) after saving the style

@nptr
Copy link
Owner

nptr commented Aug 15, 2022

I'll see what I can do. Not sure if you are able to sign despite a dummy signature being in place already, but if you are not then you might want to remove the trailing 144 bytes from the style and try again.

@gdl-blue
Copy link
Author

gdl-blue commented Aug 16, 2022

Not sure if you are able to sign despite a dummy signature

packthem.exe signs with a built in signature that Windows recognizes.

@nptr
Copy link
Owner

nptr commented Aug 16, 2022

[..] dummy signature being in place already

I am saying the style will have two signatures appended if I am not accounting for this second pass. Probably won't hurt, but I like to mention it.

@nptr nptr changed the title Automnacally sign visual style if there is packthem.exe in current directory Automatically sign visual style if 'packthem.exe' is in the current directory Aug 23, 2022
@gdl-blue
Copy link
Author

aha, multiple signing didn't make the OS have an error for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants