-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liveblog headlines module: Dark mode support #5
Comments
I've added dark-mode styles, wrapped in a media query The media query may not be a good idea because NPR is not yet consistently supporting dark mode across all of its products. So the embed may appear on a page that doesn't support dark mode. Next step: Ask the mobile team how they'd handle an element that supports dark mode, on a page that doesn’t, on a device/browser that is in dark mode. Worst-case solution: Put a white background on the embed. |
Not looking great in the android app (only place we're using dark mode right now).
For link styles, draw inspiration from how links are treated elsewhere on the site in dark mode.
One thing to look into: If the embed supports dark mode but the surrounding page does not, what happens?
The text was updated successfully, but these errors were encountered: