Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] template-oss should manage labels #69

Open
wraithgar opened this issue Feb 28, 2022 · 5 comments
Open

[FEATURE] template-oss should manage labels #69

wraithgar opened this issue Feb 28, 2022 · 5 comments

Comments

@wraithgar
Copy link
Member

The settings.yml file inheritance model does not work. We should let template-oss manage labels, if that's at all possible.

We may end up in a situation like the current one, where inheritance doesn't work. It would mean template-oss itself needs to build the settings file from its template any any optional additional file that we allow for in each repo.

@lukekarrys
Copy link
Contributor

lukekarrys commented Mar 17, 2022

For reference here is the list of labels from the wiki which might be outdated by now.

Something to keep in mind for this feature is that it should allow config if we want to apply it to the cli (such as not deleting untracked labels).

Types

Label Description
Bug things that need fixing
Question further information is requested
Docs this change only modifies documentation
Epic a larger scope of work that will be tracked in a Project Board
Backlog a "backlogged" item that will be tracked in a Project Board
Agenda will be discussed at the Open RFC call
Meeting meeting agendas
Enhancement new feature or request
Good First Issue good issue or PR for newcomers
Duplicate another pull request or issues already addresses this
Wontfix this will not be worked on
Registry specific to registry implementation
Website specific to website implementation
Security specific to security implementation
Ratified this RFC is ready for implementation
Help Wanted Help Wanted: extra attention is needed
In Progress not ready to merge yet
Needs Discussion is pending a discussion
Needs Tests requires tests before merging
Needs Documentation pull request requires docs before merging
Release {version} pull request is for a specific npm release
semver:major backwards-incompatible breaking changes
semver:minor new backwards-compatible feature
semver:patch semver patch level for changes

@nlf
Copy link
Contributor

nlf commented Jan 26, 2023

Here's the labels we want (we think)

Label Color Description
Dependencies #00cc00 Dependency updates
Needs Triage #1664ff Issue awaiting triage
Awaiting Information #ededed Needs more info to continue, like a reproduction
Priority 0 #e54572 Highest priority
Priority 1 #ba20ab Second highest priority
Priority 2 #412379 Third highest priority
Priority Backlog #000000 Not a current priority
Security #d0021b Security related issues

@wraithgar
Copy link
Member Author

the autorelease tags that release-please uses are definitely needed

@lukekarrys
Copy link
Contributor

lukekarrys commented Jan 26, 2023

here are all the labels in all of our repos, sorted by how many repos have that label. note this doesn't say anything about how many issues/prs have that label, but just gives us a baseline to not accidentally clobber anything important.

Label Color Repo Count
Dependencies #00cc00 73
autorelease: pending #ededed 67
autorelease: tagged #ededed 66
Agenda #F5A623 56
semver:patch #0E8A16 55
semver:minor #1D76DB 55
semver:major #D93F0B 55
Needs Discussion #D0021B 55
Security #D0021B 55
Backlog #000000 54
In Progress #105DE0 54
Needs Tests #D0021B 54
Needs Documentation #D0021B 54
Needs Triage #1664ff 54
:gem: Free Internet Points :gem: #fbca04 54
Priority 1 #BA20AB 54
Priority 2 #412379 54
Priority 0 #E54572 54
Windows #1d76db 53
Linux #fef2c0 53
Needs Review #D0021B 53
Enhancement #0E8A16 48
Good First Issue #0E8A16 48
Bug #E31919 42
Wontfix #000000 39
Duplicate #000000 39
Question #ededed 38
feature #80C000 20
invalid #DDDDDD 19
refactor #FF8000 18
chore #FFC000 18
cd #4080FF 18
docs #C080FF 18
ci #00C0FF 18
blocked #C00000 18
released #DDDDDD 18
Release 8.x #000000 4
Discuss #F7FE11 3
Epic #F8E71C 3
Meeting #ededed 2
Documentation #313DB0 2
Registry #ededed 2
Ratified #ededed 2
Release 6.x #000000 2
Release 7.x #000000 2
help wanted #7CF1B9 2
cli #B6476B 1
spec #F9C321 1
ratify #c2e0c6 1
ws:libnpmhook #D4C5F9 1
ws:arborist #D4C5F9 1
ws:libnpmdiff #D4C5F9 1
cmd:install #F9D0C4 1
cmd:publish #F9D0C4 1
config:include-workspace-root #FEF2C0 1
config:workspaces #FEF2C0 1
cmd:pkg #F9D0C4 1
cmd:list #F9D0C4 1
config:workspace #FEF2C0 1
cmd:update #F9D0C4 1
ws:libnpmexec #D4C5F9 1
ws:libnpmorg #D4C5F9 1
ws:libnpmpack #D4C5F9 1
ws:libnpmpublish #D4C5F9 1
ws:libnpmaccess #D4C5F9 1
ws:libnpmsearch #D4C5F9 1
ws:libnpmteam #D4C5F9 1
ws:libnpmversion #D4C5F9 1
cmd:run-script #F9D0C4 1
cmd:audit #F9D0C4 1
config:display #FEF2C0 1
ws:libnpmfund #D4C5F9 1
cmd:version #F9D0C4 1
Release 9.x #000000 1
config: lockfile #FEF2C0 1
cmd:exec #F9D0C4 1
perf #fef2c0 1
cmd:diff #F9D0C4 1
cmd:outdated #F9D0C4 1
release: manager #fbca04 1
config:global #FEF2C0 1
config:private-registry #FEF2C0 1
platform: macos #1d76db 1
Cannot Reproduce #260531 1
config:overrides #FEF2C0 1
cmd:access #F9D0C4 1
regression:9.x #E728D1 1
cmd:query #4C76B6 1
ws:config #242697 1
initiative #DC2FBF 1
provenance #7AEB62 1
backport npm9 #42F9C7 1
linked-install-strategy #1A29C5 1
audit-policies-filters #596642 1
content #705E93 1
accessibility #B8F041 1
theme #D04CB9 1
Awaiting Information #ededed 1
Priority Backlog #000000 1
pr: needs tests #D0021B 1
pr: needs documentation #D0021B 1
Community #343DFF 1
Website #E3AF50 1
Needs Rebase #D0021B 1
Release Next #000000 1
platform:windows #1d76db 1
release: next #fbca04 1
platform: linux #1d76db 1

@nlf
Copy link
Contributor

nlf commented May 3, 2023

here's the list of labels that i was going to propose for the probot settings app

labels:

  • name: Agenda
    color: "#F5A623"
    description: Will be discussed in an Open RFC call
  • name: Bug
    color: "#E31919"
    description: Issues where an existing feature is not working as intended
  • name: Dependencies
    color: "#00CC00"
    description: Dependency update pull requests
  • name: Enhancement
    color: "#0E8A16"
    description: Request for a new feature or improvement to an existing feature
  • name: Good First Issue
    color: "#0E8A16"
    description: Issues that are ideal for a new contributor to work on
  • name: Needs Discussion
    color: "#D0021B"
    description: Issues that need further discussion before prioritizing or accepting
  • name: Needs Documentation
    color: "#D0021B"
    description: Pull requests that need documentation added before merging
  • name: Needs Tests
    color: "#D0021B"
    description: Pull requests that need tests added before merging
  • name: Needs Triage
    color: "#1664FF"
    description: Issues that need to be triaged by the npm team
  • name: Priority 0
    color: "#E54572"
    description: Immediate priority
  • name: Priority 1
    color: "#BA20AB"
    description: High priority
  • name: Priority 2
    color: "#412379"
    description: Low priority
  • name: Backlog
    color: "#000000"
    description: Lowest priority
  • name: Security
    color: "#D0021B"
    description: Security related issues and pull requests
  • name: "autorelease: pending"
    color: "#EDEDED"
    description: Pull requests for releases that have not yet been published (used by bots only)
  • name: "autorelease: tagged"
    color: "#45B4D6"
    description: Pull requests for releases that have been published (used by bots only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants