Skip to content

Commit d115e20

Browse files
committed
fix: do not collapse chores for now
1 parent 8ff563d commit d115e20

11 files changed

+391
-665
lines changed

lib/content/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,6 @@ module.exports = {
203203
{ type: 'fix', section: 'Bug Fixes', hidden: false, collapse: false },
204204
{ type: 'docs', section: 'Documentation', hidden: false, collapse: false },
205205
{ type: 'deps', section: 'Dependencies', hidden: false, collapse: false },
206-
{ type: 'chore', section: 'Chores', hidden: false, collapse: true },
206+
{ type: 'chore', section: 'Chores', hidden: false, collapse: false },
207207
],
208208
}

lib/release/changelog.js

+2
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ class Changelog {
3131
#getEntries (type) {
3232
const section = this.#sections[type]
3333
const entries = this.#entries[type].map(list)
34+
// Ignoring coverage until we use this again
35+
/* istanbul ignore next */
3436
if (section?.collapse) {
3537
entries.unshift('<details><summary>Commits</summary>\n')
3638
entries.push('\n</details>')

tap-snapshots/test/apply/source-snapshots.js.test.cjs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1390,7 +1390,7 @@ release-please-config.json
13901390
"type": "chore",
13911391
"section": "Chores",
13921392
"hidden": false,
1393-
"collapse": true
1393+
"collapse": false
13941394
}
13951395
],
13961396
"prerelease-type": "pre",
@@ -3050,7 +3050,7 @@ release-please-config.json
30503050
"type": "chore",
30513051
"section": "Chores",
30523052
"hidden": false,
3053-
"collapse": true
3053+
"collapse": false
30543054
}
30553055
],
30563056
"prerelease-type": "pre",
@@ -4427,7 +4427,7 @@ release-please-config.json
44274427
"type": "chore",
44284428
"section": "Chores",
44294429
"hidden": false,
4430-
"collapse": true
4430+
"collapse": false
44314431
}
44324432
],
44334433
"prerelease-type": "pre",

tap-snapshots/test/release/release-please-cases-chore-commit.js.test.cjs

+19-21
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,15 @@ Object {
1313
---
1414
1515
16-
<details><summary>2016.0.2-pre</summary>
16+
<details><summary>2017.0.3-pre</summary>
1717
18-
## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
18+
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)
1919
2020
### Chores
2121
2222
<details><summary>Commits</summary>
2323
24-
* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
25-
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
24+
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)
2625
2726
</details>
2827
</details>
@@ -35,40 +34,39 @@ Object {
3534
"labels": Array [
3635
"autorelease: pending",
3736
],
38-
"number": 264,
39-
"sha": "675ff2fa3a03500ce5748e38d05c003d80943e43",
40-
"title": "chore: release 2016.0.2-pre",
37+
"number": 268,
38+
"sha": "9e96e7aa386e69fd38783b037402d2ffd64fb5fc",
39+
"title": "chore: release 2017.0.3-pre",
4140
}
4241
`
4342

4443
exports[`test/release/release-please.js TAP cases chore commit > releases chore commit 1`] = `
4544
Array [
4645
Object {
4746
"draft": false,
48-
"id": 132552731,
49-
"major": 2016,
47+
"id": 132694534,
48+
"major": 2017,
5049
"minor": 0,
51-
"name": "v2016.0.2-pre",
50+
"name": "v2017.0.3-pre",
5251
"notes": String(
53-
## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
52+
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)
5453
5554
### Chores
5655
5756
Commits
5857
59-
* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
60-
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
58+
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)
6159
),
62-
"patch": 2,
60+
"patch": 3,
6361
"path": ".",
6462
"pkgName": "npm-cli-release-please",
65-
"prNumber": 264,
66-
"publishTag": "prerelease-2016",
67-
"sha": "eaa230680541215efd72568054f187e8cebdd2a5",
68-
"tagName": "v2016.0.2-pre",
69-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552731/assets{?name,label}",
70-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2016.0.2-pre",
71-
"version": "2016.0.2-pre",
63+
"prNumber": 268,
64+
"publishTag": "prerelease-2017",
65+
"sha": "13b89ef2a76c624b3ebccda40ee817c4112744fc",
66+
"tagName": "v2017.0.3-pre",
67+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694534/assets{?name,label}",
68+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2017.0.3-pre",
69+
"version": "2017.0.3-pre",
7270
},
7371
]
7472
`

0 commit comments

Comments
 (0)