Skip to content

Commit 5d806ab

Browse files
authored
fix: iterate over releases from env var (#429)
This fixes an issue where single quotes within releases were not escaped. Copied directly from npm/proc-log#79
1 parent 8906397 commit 5d806ab

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

Diff for: .github/workflows/release-integration.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ jobs:
5454
- name: Publish
5555
env:
5656
PUBLISH_TOKEN: ${{ secrets.PUBLISH_TOKEN }}
57+
RELEASES: ${{ inputs.releases }}
5758
run: |
5859
EXIT_CODE=0
5960
@@ -65,7 +66,7 @@ jobs:
6566
fi
6667
}
6768
68-
for release in $(echo '${{ inputs.releases }}' | jq -r '.[] | @base64'); do
69+
for release in $(echo $RELEASES | jq -r '.[] | @base64'); do
6970
PUBLISH_TAG=$(echo "$release" | base64 --decode | jq -r .publishTag)
7071
STATUS=$(each_release "$PUBLISH_TAG")
7172
if [[ "$STATUS" -eq 1 ]]; then

Diff for: lib/content/_job-release-integration-yml.hbs

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ steps:
1515
- name: Publish
1616
env:
1717
PUBLISH_TOKEN: $\{{ secrets.PUBLISH_TOKEN }}
18+
RELEASES: $\{{ inputs.releases }}
1819
{{else}}
1920
{{> stepsSetupYml }}
2021
- name: Check If Published
@@ -30,7 +31,7 @@ steps:
3031
fi
3132
}
3233

33-
for release in $(echo '$\{{ inputs.releases }}' | jq -r '.[] | @base64'); do
34+
for release in $(echo $RELEASES | jq -r '.[] | @base64'); do
3435
{{#if publish}}
3536
PUBLISH_TAG=$(echo "$release" | base64 --decode | jq -r .publishTag)
3637
STATUS=$(each_release "$PUBLISH_TAG")

Diff for: tap-snapshots/test/apply/source-snapshots.js.test.cjs

+3-3
Original file line numberDiff line numberDiff line change
@@ -897,7 +897,7 @@ jobs:
897897
fi
898898
}
899899
900-
for release in $(echo '\${{ inputs.releases }}' | jq -r '.[] | @base64'); do
900+
for release in $(echo $RELEASES | jq -r '.[] | @base64'); do
901901
SPEC="$(echo "$release" | base64 --decode | jq -r .pkgName)@$(echo "$release" | base64 --decode | jq -r .version)"
902902
STATUS=$(each_release "$SPEC")
903903
if [[ "$STATUS" -eq 1 ]]; then
@@ -2539,7 +2539,7 @@ jobs:
25392539
fi
25402540
}
25412541
2542-
for release in $(echo '\${{ inputs.releases }}' | jq -r '.[] | @base64'); do
2542+
for release in $(echo $RELEASES | jq -r '.[] | @base64'); do
25432543
SPEC="$(echo "$release" | base64 --decode | jq -r .pkgName)@$(echo "$release" | base64 --decode | jq -r .version)"
25442544
STATUS=$(each_release "$SPEC")
25452545
if [[ "$STATUS" -eq 1 ]]; then
@@ -4053,7 +4053,7 @@ jobs:
40534053
fi
40544054
}
40554055
4056-
for release in $(echo '\${{ inputs.releases }}' | jq -r '.[] | @base64'); do
4056+
for release in $(echo $RELEASES | jq -r '.[] | @base64'); do
40574057
SPEC="$(echo "$release" | base64 --decode | jq -r .pkgName)@$(echo "$release" | base64 --decode | jq -r .version)"
40584058
STATUS=$(each_release "$SPEC")
40594059
if [[ "$STATUS" -eq 1 ]]; then

0 commit comments

Comments
 (0)