Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checkSignatures to registry.manifest #170

Merged
merged 1 commit into from
May 17, 2022

Conversation

wraithgar
Copy link
Member

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner May 12, 2022 16:32
@wraithgar
Copy link
Member Author

If you pass NO keys for the registry being fetched from, this logic is bypassed. This is so that this flag can be turned on without breaking existing folks who don't have the keys in their config, nor are sending it to pacote in places.

@wraithgar wraithgar force-pushed the gar/integrity-signature branch from 790dfa8 to 008a79e Compare May 12, 2022 16:36
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good!

@wraithgar wraithgar requested a review from feelepxyz May 12, 2022 17:36
lib/registry.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@wraithgar wraithgar force-pushed the gar/integrity-signature branch from 008a79e to dd2001b Compare May 16, 2022 18:01
@wraithgar wraithgar requested a review from feelepxyz May 16, 2022 18:01
lib/registry.js Outdated Show resolved Hide resolved
@wraithgar wraithgar force-pushed the gar/integrity-signature branch from dd2001b to dac13e2 Compare May 17, 2022 16:32
@wraithgar wraithgar merged commit f9ab442 into main May 17, 2022
@wraithgar wraithgar deleted the gar/integrity-signature branch May 17, 2022 18:40
This was referenced May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants