fix: inc prerelease with numeric preid #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semver spec says prerelease can be numeric:
This PR fixes
inc
prerelease
with numericpreid
.E.g.
inc('1.0.0-1.0', 'prerelease', '1')
should return1.0.0-1.1
, but today it returns1.0.0-1.0
.The bug is that currently it compares preid with
this.prerelease[0] === identifier
, and a string'1'
is not equal to number1
, thus it's returning incorrect result. Change this comparison to usecompareIdentifiers
just like everywhere else fixes the problem.npm version prerelease
does not work with numeric--preid
cli#3181