Skip to content

Commit 16a021e

Browse files
committed
fix: throw on bad version
1 parent 503a4e5 commit 16a021e

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

functions/diff.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
const parse = require('./parse')
1+
const SemVer = require('../classes/semver')
22

33
const diff = (version1, version2) => {
4-
const v1 = parse(version1)
5-
const v2 = parse(version2)
4+
const v1 = new SemVer(version1)
5+
const v2 = new SemVer(version2)
66
const comparison = v1.compare(v2)
77

88
if (comparison === 0) {

test/functions/diff.js

+10
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,13 @@ test('diff versions test', (t) => {
4343

4444
t.end()
4545
})
46+
47+
test('throws on bad version', (t) => {
48+
t.throws(() => {
49+
diff('bad', '1.2.3')
50+
}, {
51+
message: 'Invalid Version: bad',
52+
name: 'TypeError',
53+
})
54+
t.end()
55+
})

0 commit comments

Comments
 (0)