Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the npm lint script on CI. #604

Closed
wants to merge 1 commit into from
Closed

Use the npm lint script on CI. #604

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

This should be more consistent since it should use the specified standard version and not the latest one.

@XhmikosR XhmikosR requested a review from a team as a code owner December 16, 2019 15:10
@isaacs
Copy link
Contributor

isaacs commented Dec 16, 2019

This should be more consistent since it should use the specified standard version and not the latest one.

Note: npx will use the version installed in node_modules if it exists. It only pulls the latest if there isn't something else specified locally. But abstracting it out in case we change our linter at some point in the future is not a bad idea anyway, so at least it's only defined in one place.

@XhmikosR
Copy link
Contributor Author

Oh, cool, I wasn't aware of that. But yeah, this does feel better to me, more consistent.

@mikemimik mikemimik added this to the OSS - Sprint 1 milestone Dec 17, 2019
@mikemimik mikemimik added Community Enhancement new feature or improvement semver:patch semver patch level for changes labels Dec 19, 2019
@mikemimik mikemimik self-assigned this Dec 19, 2019
mikemimik
mikemimik approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemimik
Copy link
Contributor

nit: We might want to address the failing tests

@XhmikosR
Copy link
Contributor Author

Might be worth bumping standard to the version that supports the Node.js versions you guys support so that everything is aligned.

@XhmikosR
Use the npm lint script on CI.
562cfe0 
This should be more consistent since it should use the specified standard version and not the latest one.
@mikemimik mikemimik added the Release 6.x work is associated with a specific npm 6 release label Jan 21, 2020
@mikemimik mikemimik closed this in 7852c0c Jan 28, 2020
@XhmikosR XhmikosR deleted the lint branch January 29, 2020 07:01
@Theo13111 Theo13111 mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemimik mikemimik mikemimik approved these changes

Assignees

@mikemimik mikemimik

Labels
Enhancement new feature or improvement Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Milestone
OSS - Sprint 2
Development

Successfully merging this pull request may close these issues.
4 participants
@XhmikosR @isaacs @mikemimik @darcyclarke