Release: [email protected] #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
release-next-6.10.0
branch
3 times, most recently
from
dcf460b to
ce38c46
Compare
This fixes a ERR_INVALID_OPT_VALUE error on Node v12
Several changes to the test suite to support running tests in parallel, bringing the overall test time down considerably. - Replace all literal 1337 and 1234 ports with a custom per-process port assignment based on the TAP_CHILD_ID environment variable. - Add common.pkg as a per-test working directory instead of polluting __dirname or accidentally reusing the same working directory for multiple tests. - Rework test config handling so that tests don't rely on config setup being run in a particular order. - Remove the npm-registry-couchapp tests, since it (a) relies on CouchDB, (b) is no longer a reliable indicator of registry compatibility, and (c) is already superceded in most cases by tests that use npm-registry-mock. (A test suite that runs against a reference implementation is a thing that should exist, but not here.) - Remove the fake-registry logging when TAP_CHILD_ID is set, since this is extremely hard to make sense of when running multiple tests in parallel. When Node v6 compatibility is dropped in npm v7, we can upgrade to the latest version of tap for a bit more speed, dropping Domains (and the associated deprecation warnings), and a fancier test reporter.
Add a special case for 'remote' deps (tarballs). Before b7b54f2 the package names were possibly just looked up in the registry instead. See https://npm.community/t/6187 Close: #180
Close: #183
implementation added in #31
I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.
Signed-off-by: ossdev <[email protected]>
npm find local node.exe on windows, but relies on global node installation on linux. Added a test to check for a local installation of node before relying on the system wide installation. Close: #200
Never include /.git in the package. It creates packages that, once installed, can not be easily removed. Prevent .DS_Store files from being picked up if they are files rather than folders. (Note that a .DS_Store file in a specifically included dir _will_ still be included.) Don't bother walking node_modules in the root if no packages are bundled. (Saves thousands of lstat calls on npm publish in normal cases.) Sort package file lists in the tarball to optimize for gzip compression.
Fixes a bug related to FSReqWrap on Node v12, and incorrect encoding/decoding of base-256 numeric values.
Fix: npm/npm#17858 Fix: npm/npm#18042 Fix: https://npm.community/t/issue-npm-dedupe-crash-with-typeerror-cannot-read-property-0-of-undefined/644/3 Close: #201 This fixes a bug where a package folder might have a package.json which is missing or lacks a name property. It also properly detects the scoped-ness of a package folder even if the package name is not scoped, since one might install `express@npm:@scope/express` and end up in that state.
Total luxury problem. There are too many cores on my laptop, so commands kick off and complete too quickly, resulting in not properly demonstrating the behavior that this test is looking for.
isaacs
force-pushed
the
release-next-6.10.0
branch
from
ce38c46 to
cf4f072
Compare
isaacs
force-pushed
the
release-next-6.10.0
branch
2 times, most recently
from
4b83db6 to
42bd015
Compare
Missed this on the review. Minor nit, not worth rebasing, now that the release is almost ready to ship.
isaacs
force-pushed
the
release-next-6.10.0
branch
from
42bd015 to
36ddc3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v6.10.0 (TBD):
FEATURES
87fef4e35#176 fix: Always return JSON for outdated --json (@sreeramjayan)f101d44fc#203 fix(unpublish): add space after hyphen (@ffflorian)a4475de4c#202 enable production flag for npm audit (@CalebCourier)d192904d0#178 fix: Return a value forviewwhen in silent mode (@stayradiated)39d473adf#185 Allow git to follow global tagsign config (@junderw)BUGFIXES
d9238af0b#201 npm/npm#17858 npm/npm#18042 npm.community#644 do not crash when removing nameless packages (@SteveVanOpstal and @isaacs)4bec4f111#200 Check fornode(as well asnode.exe) in npm's local dir on Windows (@rgoulais)ce93dab2d#180 npm.community#6187 Fix handling ofremotedeps innpm outdated(@larsgw)TESTING
a823f3084travis: Update to include new v12 LTS (@isaacs)33e2d1dacfix flaky debug-logs test (@isaacs)e9411c6cdDon't time out waiting for gpg user input (@isaacs)d2d301704#195 Add the arm64 check for legacy-platform-all.js test case. (@ossdev07)a4dc34243parallel tests (@isaacs)DOCUMENTATION
f5857e263#192 Clarify usage of bundledDependencies (@john-osullivan)747fdaf66#159 doc: add --audit-level param (@ngraef)DEPENDENCIES
e36b3c320[email protected] (@isaacs)6bb935c09[email protected] (@isaacs)e9cd536Use custom cachingrealpathimplementation, dramatically reducinglstatcalls when reading the package tree (@isaacs)39538b460[email protected] (@isaacs)f8b1552#38 Ignore errors raised byfs.closeSync(@lukeapage)042193069[email protected] (@isaacs)8bbd051#172 limit git retry times, avoid unlimited retries (小秦)92f5e4c#170 fix(errors): Fix "TypeError: err.code.match is not a function" error (@jviotti)8bd8e909f[email protected] (@isaacs)47de8f5#146 npm.community#2395 fix(config): Add ssri config 'error' option (@larsgw)5156561fix(write): avoid acb never calledsituation (@zkat)90f40f0#166 #165 docs: Fix docs forpathproperty in get.info (@hdgarrood)bf61c45c6[email protected] (@isaacs)f75d46a9d[email protected] (@isaacs)c80341a#215 Fix encoding/decoding of base-256 numbers (@justfalter)77522f0#204 #214 Usestatinstead oflstatwhen checking CWD (@stkb)ec6236210[email protected] (@isaacs)63d1e3e#30 Sort package tarball entries by file type for compression benefits (@isaacs)7fcd045Ignore.DS_Storefiles as well as folders (@isaacs)68b7c96Never include .git folders in package root. (Note: this prevents the issue that broke the v6.9.1 release.) (@isaacs)57bef61bcupdate fstream in node-gyp (@isaacs)acbbf7eee#183 [email protected] (@kemitchell)011ae67f0[email protected] (@isaacs)f5e884909[email protected] (@isaacs)b57d07e35[email protected] (@isaacs)