Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] readable-stream v3.6.0 fixes prototype modification brittleness #824

Closed
ljharb opened this issue Feb 14, 2020 · 3 comments
Closed
Labels
Enhancement new feature or improvement semver:minor new backwards-compatible feature semver:patch semver patch level for changes

Comments

@ljharb
Copy link
Contributor

ljharb commented Feb 14, 2020

What / Why

it uses the proper babel transform, so it’s now spec-compliant and not vulnerable to Object.prototype modification.

It'd be great to get this into a v6 release (esp since it's unlikely that v7 will use readable-stream).

(cc @mikemimik, per https://node-js.slack.com/archives/C0J6DJ4PL/p1581699856037300)

see nodejs/readable-stream#428

@mikemimik mikemimik added Community Enhancement new feature or improvement semver:minor new backwards-compatible feature semver:patch semver patch level for changes labels Feb 14, 2020
@Sief6
Copy link

Sief6 commented Feb 16, 2020

يستخدم تحويل بابل الصحيح ، لذلك أصبح الآن متوافقًا مع المواصفات وغير عرضة لتعديل Object.prototype.

سيكون من الرائع الحصول على هذا الإصدار v6 (esp لأنه من غير المحتمل أن يستخدم الإصدار v7 الدفق القابل للقراءة).

( ccmikemimik ، لكل https://node-js.slack.com/archives/C0J6DJ4PL/p1581699856037300 )

Edit (from @mikemimik):

Created from translate.google.com

Correct Babylon conversion is used, so it's now compliant with specifications and not subject to modifying Object.prototype.

It would be nice to have this v6 version (esp because v7 is unlikely to use readable stream).

@Sief6

This comment has been minimized.

@darcyclarke
Copy link
Contributor

Closing as this should/would have gotten fixed in 6.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement semver:minor new backwards-compatible feature semver:patch semver patch level for changes
Projects
None yet
Development

No branches or pull requests

5 participants
@ljharb @darcyclarke @mikemimik @Sief6 and others