Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] npm publish --dry-run For script prepare void #5210

Closed
2 tasks done
shinelp100 opened this issue Jul 22, 2022 · 3 comments · Fixed by #6861
Closed
2 tasks done

[BUG] npm publish --dry-run For script prepare void #5210

shinelp100 opened this issue Jul 22, 2022 · 3 comments · Fixed by #6861
Assignees
@jpg619
Labels
Bug thing that needs fixing cmd:publish related to `npm publish` Documentation documentation related issue Priority 1 high priority issue

Comments

@shinelp100
Copy link

shinelp100 commented Jul 22, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

This is a CLI Docs Problem, not another kind of Docs Problem.

  • This is a CLI Docs Problem.

Description of Problem

npm publish --dry-run For script prepare void

prepare will not run during --dry-run

"scripts": { "jest": "jest", "prepare": "npx husky install" },

node: 16.15.0
npm: 8.5.5

image

Potential Solution

No response

Affected URL

No response
@shinelp100 shinelp100 added Documentation documentation related issue Needs Triage needs review for next steps labels Jul 22, 2022
@shinelp100 shinelp100 changed the title [BUG] <npm publish --dry-run For script prepare void> [BUG] npm publish --dry-run For script prepare void Jul 25, 2022
@fritzy fritzy added Priority 1 high priority issue cmd:publish related to `npm publish` Bug thing that needs fixing and removed Needs Triage needs review for next steps labels Jul 27, 2022
@fritzy
Copy link
Contributor

fritzy commented Jul 27, 2022

The documentation says that --dry-run should not run prepare, but it currently does.

@jpg619 jpg619 self-assigned this Sep 26, 2023
@jpg619
Copy link
Contributor

jpg619 commented Oct 3, 2023

What are the steps to reproduce the issue?

@wraithgar
Copy link
Member

@jpg619 this is a documentation issue, the docs need to reflect how npm 7 and up do things.

@jpg619 jpg619 mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpg619 jpg619

Labels
Bug thing that needs fixing cmd:publish related to `npm publish` Documentation documentation related issue Priority 1 high priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: npm publish content modification jpg619/cli
4 participants
@wraithgar @fritzy @shinelp100 @jpg619