fix(view): Show the correct publish date for versions selected by range #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Sep 13, 2021
|
Really good catch here, thank you. Just one note on making sure we're testing this new behavior, but other than that this is obviously the correct solution. |
wraithgar
approved these changes
Sep 13, 2021
Before, `npm view npm@^6` would incorrectly report “published over a year from now” for every entry. Now it reports the correct dates. PR-URL: npm#3739 Credit: @andersk Close: npm#3739 Reviewed-by: @wraithgar
wraithgar
force-pushed
the
view-date
branch
from
9160b73
to
0320bd7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
npm view npm@^6would incorrectly report “published over a year from now” for every entry. Now it reports the correct dates.