Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error-message): clean urls from 404 error #3732

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

wraithgar
Copy link
Member

If the package being installed is a url it needs to be cleaned before
logging so passwords aren't potentially logged.

@wraithgar wraithgar requested a review from a team as a code owner September 9, 2021 18:14
@wraithgar
Copy link
Member Author

The wording was updated to not just say "npm registry" since this is just a generic 404 handler, it could be from any registry.

Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better. i agree with the wording change here too 👍

If the package being installed is a url it needs to be cleaned before
logging so passwords aren't potentially logged.

PR-URL: #3732
Credit: @wraithgar
Close: #3732
Reviewed-by: @nlf
@wraithgar wraithgar merged commit 1ad0938 into release-next Sep 9, 2021
@wraithgar wraithgar deleted the gar/creds-in-error branch September 9, 2021 19:34
@wraithgar wraithgar mentioned this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants