fix windows race condition

Author: jenseng

workspaces/libnpmexec/lib/with-lock.js

@@ -87,7 +87,7 @@ function acquireLock (lockPath) {
       }
       if (status === 'stale') {
         // there is a very tiny window where another process could also release the stale lock and acquire it before we release it here; the lock compromise checker should detect this and throw an error
-        deleteLock(lockPath)
+        deleteLock(lockPath, ['ENOENT', 'EBUSY']) // on windows, EBUSY can happen if another process is creating the lock; we'll just retry
       }
       return await acquireLock(lockPath)
     }
@@ -100,12 +100,12 @@ function acquireLock (lockPath) {
   })
 }
 
-function deleteLock (lockPath) {
+function deleteLock (lockPath, ignoreCodes = ['ENOENT']) {
   try {
     // synchronous, so we can call in an exit handler
     rmdirSync(lockPath)
   } catch (err) {
-    if (err.code !== 'ENOENT') {
+    if (!ignoreCodes.includes(err.code)) {
       throw err
     }
   }

workspaces/libnpmexec/test/with-lock.js

@@ -133,6 +133,7 @@ t.test('concurrent stale lock takeover', async (t) => {
     withLock(lockPath, () => 'lock2'),
     withLock(lockPath, () => 'lock3'),
   ])
+  console.log(results)
   // all locks should either be successfully acquired or get compromised (expected occasional race condition)
   t.ok(results.every(result => result.status === 'fulfilled' || result.status === 'rejected' && result.reason.code === 'ECOMPROMISED'))
 })