Skip to content

Commit 3a4d42b

Browse files
isaacsclaudiahdz
authored andcommitted
test: fix git configs for git 2.23 and above
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
1 parent abfe0a5 commit 3a4d42b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Diff for: lib/install/inflate-shrinkwrap.js

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ function tarballToVersion (name, tb) {
8484
} else {
8585
matchRegTarball = new RegExp(`^${registry}(.*)?/-/\\1-(.*)[.]tgz$`)
8686
}
87+
if (!tb) return
8788
const match = tb.match(matchRegTarball)
8889
if (!match) return
8990
return match[2] || match[1]

Diff for: test/common-tap.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ exports.makeGitRepo = function (params, cb) {
193193
git.chainableExec(['config', 'user.name', user], opts),
194194
git.chainableExec(['config', 'user.email', email], opts),
195195
// don't time out tests waiting for a gpg passphrase or 2fa
196-
git.chainableExec(['config', 'commit.gpgsign', 'false'], opts),
196+
git.chainableExec(['config', 'commit.gpgSign', 'false'], opts),
197+
git.chainableExec(['config', 'tag.gpgSign', 'false'], opts),
197198
git.chainableExec(['config', 'tag.forceSignAnnotated', 'false'], opts),
198199
git.chainableExec(['add'].concat(added), opts),
199200
git.chainableExec(['commit', '-m', message], opts)

0 commit comments

Comments
 (0)