From 684f16ca7d29e9b03361652ad446792da2c4611c Mon Sep 17 00:00:00 2001
From: Shay Rojansky <roji@roji.org>
Date: Sat, 16 Dec 2023 23:33:02 +0200
Subject: [PATCH] Fix PgTableValuedFunctionExpression cloning

Fixes #3023
---
 .../Internal/PgTableValuedFunctionExpression.cs          | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/EFCore.PG/Query/Expressions/Internal/PgTableValuedFunctionExpression.cs b/src/EFCore.PG/Query/Expressions/Internal/PgTableValuedFunctionExpression.cs
index 360e06da8..19c153129 100644
--- a/src/EFCore.PG/Query/Expressions/Internal/PgTableValuedFunctionExpression.cs
+++ b/src/EFCore.PG/Query/Expressions/Internal/PgTableValuedFunctionExpression.cs
@@ -21,7 +21,8 @@ namespace Npgsql.EntityFrameworkCore.PostgreSQL.Query.Expressions.Internal;
 ///         doing so can result in application failures when updating to a new Entity Framework Core release.
 ///     </para>
 /// </remarks>
-public class PgTableValuedFunctionExpression : TableValuedFunctionExpression, IEquatable<PgTableValuedFunctionExpression>
+public class PgTableValuedFunctionExpression : TableValuedFunctionExpression,
+    IEquatable<PgTableValuedFunctionExpression>, IClonableTableExpressionBase
 {
     /// <summary>
     ///     The name of the column to be projected out from the <c>unnest</c> call.
@@ -80,6 +81,12 @@ public override PgTableValuedFunctionExpression Update(IReadOnlyList<SqlExpressi
             ? new PgTableValuedFunctionExpression(Alias, Name, arguments, ColumnInfos, WithOrdinality)
             : this;
 
+    // TODO: This is a hack for https://github.com/npgsql/efcore.pg/issues/3023; we notably don't visit the arguments, which we should
+    // (but can't, since the Clone() API doesn't accept the cloning visitor).
+    /// <inheritdoc />
+    public TableExpressionBase Clone()
+        => new PgTableValuedFunctionExpression(Alias, Name, Arguments, ColumnInfos, WithOrdinality);
+
     /// <inheritdoc />
     protected override void Print(ExpressionPrinter expressionPrinter)
     {