Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing should use /filter instead of /{config,status} #8

Open
misiupajor opened this issue Sep 25, 2017 · 2 comments
Open

Listing should use /filter instead of /{config,status} #8

misiupajor opened this issue Sep 25, 2017 · 2 comments

Comments

@misiupajor
Copy link

First of all, I would like to thank you for taking your time to develop this, but also for the shared thought of how this can be used with Ansible. Nice touch!

I have gone through your code and a concern I have is the heavy use of /status, but also /config for fetching object information. I would highly recommend that you use the /filter method for that instead, as we may be deprecating the /status method with time. In addition: the /filter method can also give you more control of what information OP5 sends back to the client (with the ?columns= parameter).

@np422
Copy link
Owner

np422 commented Sep 26, 2017

Thank you very much for the feedback and information, I've started to do a refactoring from this first version and this information is very well received and timely delivered for that work.

@misiupajor
Copy link
Author

Most welcome and thank you for the prompt response 👍I look forward to the refactoring and rest assured, I'll be keeping an eye on this repository and give feedback where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants