Fix index out of bounds error when building status (nginx#3513)

Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well.

Solution: Adjust the logic to ensure we don't access indices that are out of bounds.

ADD Nginx Gateway HPA(nginx#3447)

Author: sjberman

charts/nginx-gateway-fabric/templates/hpa.yaml

@@ -2,7 +2,7 @@
 apiVersion: {{ ternary "autoscaling/v2" "autoscaling/v2beta2" (.Capabilities.APIVersions.Has "autoscaling/v2") }}
 kind: HorizontalPodAutoscaler
 metadata:
-  {{- with .Values.autoscaling.annotations }}
+  {{- with .Values.nginxGateway.autoscaling.annotations }}
   annotations: {{ toYaml . | nindent 4 }}
   {{- end }}
   labels:
@@ -17,18 +17,18 @@ spec:
     apiVersion: apps/v1
     kind: Deployment
     name: {{ include "nginx-gateway.fullname" . }}
-  minReplicas: {{ .Values.autoscaling.minReplicas }}
-  maxReplicas: {{ .Values.autoscaling.maxReplicas }}
+  minReplicas: {{ .Values.nginxGateway.autoscaling.minReplicas }}
+  maxReplicas: {{ .Values.nginxGateway.autoscaling.maxReplicas }}
   metrics:
-  {{- with .Values.autoscaling.targetMemoryUtilizationPercentage }}
+  {{- with .Values.nginxGateway.autoscaling.targetMemoryUtilizationPercentage }}
   - type: Resource
     resource:
       name: memory
       target:
         type: Utilization
         averageUtilization: {{ . }}
   {{- end }}
-  {{- with .Values.autoscaling.targetCPUUtilizationPercentage }}
+  {{- with .Values.nginxGateway.autoscaling.targetCPUUtilizationPercentage }}
   - type: Resource
     resource:
       name: cpu
@@ -39,7 +39,7 @@ spec:
   {{- with .Values.autoscalingTemplate }}
   {{- toYaml . | nindent 2 }}
   {{- end }}
-  {{- with .Values.autoscaling.behavior }}
+  {{- with .Values.nginxGateway.autoscaling.behavior }}
   behavior:
     {{- toYaml . | nindent 4 }}
   {{- end }}

charts/nginx-gateway-fabric/values.yaml

@@ -157,6 +157,7 @@ nginxGateway:
   topologySpreadConstraints: []
 
   autoscaling:
+    # Enable or disable Horizontal Pod Autoscaler
     enabled: false
     annotations: {}
     minReplicas: 1
@@ -252,8 +253,6 @@ nginx:
   # plane will copy these secrets into any namespace where NGINX is deployed.
   imagePullSecrets: []
 
-  resources: {}
-
   # Configuration for NGINX Plus usage reporting.
   usage:
     # -- The name of the Secret containing the JWT for NGINX Plus usage reporting. Must exist in the same namespace

internal/controller/status/prepare_requests.go

@@ -103,11 +103,11 @@ func removeDuplicateIndexParentRefs(parentRefs []graph.ParentRef) []graph.Parent
 		idxToParentRef[ref.Idx] = append(idxToParentRef[ref.Idx], ref)
 	}
 
-	results := make([]graph.ParentRef, len(idxToParentRef))
+	results := make([]graph.ParentRef, 0, len(idxToParentRef))
 
 	for idx, refs := range idxToParentRef {
 		if len(refs) == 1 {
-			results[idx] = refs[0]
+			results = append(results, refs[0])
 			continue
 		}
 
@@ -124,7 +124,7 @@ func removeDuplicateIndexParentRefs(parentRefs []graph.ParentRef) []graph.Parent
 				}
 			}
 		}
-		results[idx] = winningParentRef
+		results = append(results, winningParentRef)
 	}
 
 	return results

internal/controller/status/prepare_requests_test.go

@@ -445,7 +445,7 @@ func TestBuildHTTPRouteStatuses(t *testing.T) {
 
 		err := k8sClient.Get(context.Background(), nsname, &hr)
 		g.Expect(err).ToNot(HaveOccurred())
-		g.Expect(helpers.Diff(expected, hr.Status)).To(BeEmpty())
+		g.Expect(expected.RouteStatus.Parents).To(ConsistOf(hr.Status.Parents))
 	}
 }
 
@@ -524,7 +524,7 @@ func TestBuildGRPCRouteStatuses(t *testing.T) {
 
 		err := k8sClient.Get(context.Background(), nsname, &hr)
 		g.Expect(err).ToNot(HaveOccurred())
-		g.Expect(helpers.Diff(expected, hr.Status)).To(BeEmpty())
+		g.Expect(expected.RouteStatus.Parents).To(ConsistOf(hr.Status.Parents))
 	}
 }
 
@@ -601,7 +601,7 @@ func TestBuildTLSRouteStatuses(t *testing.T) {
 
 		err := k8sClient.Get(context.Background(), nsname, &hr)
 		g.Expect(err).ToNot(HaveOccurred())
-		g.Expect(helpers.Diff(expected, hr.Status)).To(BeEmpty())
+		g.Expect(expected.RouteStatus.Parents).To(ConsistOf(hr.Status.Parents))
 	}
 }