Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 68 error timeout #90

Closed
wants to merge 4 commits into from
Closed

Issue 68 error timeout #90

wants to merge 4 commits into from

Conversation

MariuszDabrowski
Copy link
Member

The API does not return errors so the user is usually left starting at the loading icon while nothing happens:

  • If the data takes longer than 7 seconds to come back I show the user an error.
  • If for some reason the data comes back after 7 seconds it will hide the error and show.

To test this you can change your slow down your network connection in chrome.

@MariuszDabrowski MariuszDabrowski linked an issue Apr 20, 2020 that may be closed by this pull request
Cancel the fetch request if nothing comes back after 20 seconds #68
Open
@MariuszDabrowski MariuszDabrowski deleted the issue-68-error-timeout branch April 20, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duliodenis duliodenis Awaiting requested review from duliodenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel the fetch request if nothing comes back after 20 seconds
1 participant
@MariuszDabrowski