Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify crate not actually including license text #526

Closed
erickt opened this issue Aug 17, 2023 · 2 comments
Closed

notify crate not actually including license text #526

erickt opened this issue Aug 17, 2023 · 2 comments

Comments

@erickt
Copy link
Contributor

erickt commented Aug 17, 2023

In #514, I requested that the license text be included in the crate. This was supposed to be fixed in #464, but it appears that the text hasn't actually gotten into the crate. This can be easiest to see on docs.rs:

Are the releases being cut from a windows machine? If that's the case, I'm guessing these files are symlinks on unix, but maybe windows isn't interpreting them as symlinks, and is just including their contents?
@0xpr03
Copy link
Member

0xpr03 commented Aug 18, 2023 •
edited
Loading

Are the releases being cut from a windows machine

Yep, that's the issue. But it shouldn't be the case anymore since #520 with the upcoming release, as no symlinks are in use anymore.

@0xpr03
Copy link
Member

0xpr03 commented Aug 21, 2023

Fixed by #520

@0xpr03 0xpr03 closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erickt @0xpr03