Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all Services overrides and reconcile with upstream changes #46

Closed
10 of 11 tasks
Tracked by #65
ShanaLMoore opened this issue Dec 11, 2023 · 0 comments
Closed
10 of 11 tasks
Tracked by #65
Assignees

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Dec 11, 2023

Acceptance Criteria

  • Services overrides are reconciled with upstream changes

Notes

ref: GBH

Files generated following playbook article: https://playbook-staging.notch8.com/en/dev/ruby/decorators-and-class-eval

  • app/services/hyrax/manifest_builder_service_decorator.rb
  • app/services/hyrax/collections/permissions_service_decorator.rb
  • app/services/hyrax/collections/permissions_create_service_decorator.rb
  • app/services/hyrax/admin_set_create_service_decorator.rb
  • app/services/hyrax/permission_manager_decorator.rb

Also search for the word OVERRIDE within any service file

  • app/services/hyrax/collection_types/create_service.rb
  • app/services/hyrax/work_thumbnail_path_service.rb
  • app/services/hyrax/thumbnail_path_service.rb
  • app/services/hyrax/indexes_thumbnails.rb
  • app/services/hyrax/quick_classification_query.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants