Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Notation CLI release assets with Notation GitHub Actions #973

Open
FeynmanZhou opened this issue Jun 18, 2024 · 2 comments
Open

Sign Notation CLI release assets with Notation GitHub Actions #973

FeynmanZhou opened this issue Jun 18, 2024 · 2 comments
Labels
enhancement New feature or request need discussion

Comments

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Jun 18, 2024

Is your feature request related to a problem?

CNCF provides a tool Clomonitor to run OpenSSF Security Best Practice checks on CNCF projects. There is a signing related check that has not been passed in the security check items. See https://clomonitor.io/projects/cncf/notary#notation_security.

According to OpenSSF Scorecard signing check criteria, a .sig file should be generated in the Notation release assets so the signature could be detected by OpenSSF Scorecard check tool. To meet the OpenSSF security best practice, we need to sign the Notation CLI release assets.

image

What solution do you propose?

Notation provides GitHub Actions for signing and verification that can be easily used in GitHub Actions Workflow and release process.

There are a few dependencies before implementing the signing flow in the release process, such as blob signing and timestamping which are working in progress. Retrieve signing key from GitHub infra as articulated in #905 might another dependency. It's recommended to sign Notation CLI release assets with Notation GitHub Actions after these dependencies are supported in upcoming releases.

What alternatives have you considered?

N/A

Any additional context?

N/A

@FeynmanZhou FeynmanZhou added enhancement New feature or request triage Need to triage labels Jun 18, 2024
Copy link

This issue is stale because it has been opened for 60 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

@github-actions github-actions bot added the Stale label Aug 21, 2024
@yizha1 yizha1 removed the Stale label Aug 26, 2024
Copy link

This issue is stale because it has been opened for 60 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 26, 2024
@yizha1 yizha1 removed the Stale label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need discussion
Projects
Status: Todo
Development

No branches or pull requests

2 participants