Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onHoverColor property #6

Closed
rmahmadkhan opened this issue Aug 29, 2022 · 9 comments
Closed

Add onHoverColor property #6

rmahmadkhan opened this issue Aug 29, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@rmahmadkhan
Copy link

rmahmadkhan commented Aug 29, 2022

Usually pull down buttons on web have color change on hover over the action item.
See the following example:

Screenshot 2022-08-29 at 11 57 46 PM

Following properties maybe needed:

  • onHoverColor
  • onHoverTextStyle or onHoverTextColor
  • onHover callback
@notDmDrl
Copy link
Owner

Hi @rmahmadkhan

I don't think that in iOS pull-down menus have onHover properties.

This package attempts to recreate a mobile (iOS) look for pull-down menus.

For more desktop/web apple-like menus you should probably try this: https://pub.dev/packages/macos_ui#pulldownbutton

If you still want to use my package please let me know, I'll try to come up with something.

@rmahmadkhan
Copy link
Author

rmahmadkhan commented Sep 5, 2022

Hi @notDmDrl

Thank you for replying. As you suggested, I tried that and other packages as well. But your package suits best for my need as it is very simple. I just need the colorOnHover (highlight color) property.

I really wish I could open a pull request for this but too busy with my work already.

It would be really great if you can make some time to add that asap

@notDmDrl
Copy link
Owner

notDmDrl commented Sep 5, 2022

@rmahmadkhan ok, no promises but i'll try to do it tomorrow 😃

@rmahmadkhan
Copy link
Author

@notDmDrl Awesome! Grateful for that!

@notDmDrl
Copy link
Owner

notDmDrl commented Sep 6, 2022

@rmahmadkhan

I have just published an update with mouse pointers and onHoverColor support.

PullDownButtonTheme(
  onHoverColor: Colors.grey,
)

or

PullDownMenuItem(
  onTap: ...,
  title: ...,
  onHoverColor: Colors.grey,
)

Let me know if this is what you needed, thx

@rmahmadkhan
Copy link
Author

rmahmadkhan commented Sep 6, 2022

@notDmDrl Thank you for doing this.
this is almost what I need. but need onHoverTextStyle property as well. As, it won't change the textColor on hover the item :(

Would really appreciate if you can add that as well

@notDmDrl
Copy link
Owner

notDmDrl commented Sep 6, 2022

@rmahmadkhan gotcha, might squeeze in a bit of time tomorrow morning for it

@notDmDrl
Copy link
Owner

notDmDrl commented Sep 7, 2022

@rmahmadkhan

Another update is live, this time with onHoverTextStyle support.

PullDownButtonTheme(
  onHoverTextStyle: ...,
)

or

PullDownMenuItem(
  onTap: ...,
  title: ...,
  onHoverTextStyle: ...,
)

@notDmDrl notDmDrl added the enhancement New feature or request label Sep 7, 2022
@rmahmadkhan
Copy link
Author

@notDmDrl Thank you for taking out time and doing this. Appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants