Fix: Only consider functions with a single argument as function-style rules #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some further real-world testing and found another heuristic we can use to ensure we only detect actual function-style rules (reducing false positives).
All function-styles rules should have the single
context
argument. This is needed so the rule can usecontext.report(...)
to report violations.Note that while we are now checking for a single argument, we are not checking anything about this argument, as it could have different names (doesn't have to be named
context
) or could use destructuring if desired.This idea was also suggested here: #81 (comment)
Fixes #81.
Part of v4 release (#120).
https://eslint.org/docs/developer-guide/working-with-rules-deprecated