Skip to content

Fix NIP46 RPC response parsing when processing the response of a 'nip04_decrypt' method #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pleb5 opened this issue Apr 3, 2024 · 0 comments · Fixed by #202
Closed

Comments

@Pleb5
Copy link
Contributor

Pleb5 commented Apr 3, 2024

This simple bug makes nip04 remote decryption - i.e. DM-s completely unusable with nsec bunkers until fixed.

In the response parsing part of the decryption method, there is a redundant JSON.parse() call on the response.result object instead of resolving the Promise with 'response.result' as it is (as is the case in the encryption method).

Made a PR for convenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant