-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.10 ignores double "##" #148
Labels
Milestone
Comments
3 tasks
6 tasks
The option to ignore the comments is quite useful. Our use-case is to have more info about the format: # Using existing Communication secret. It MUST be in the `botkube` Namespace.
## Secret format:
## stringData:
## comm_config.yaml: |
## communications:
## # Here specify settings for each app, like Slack, Mattermost etc.
## # NOTE: Use setting format visible below.
existingSecretName: "" I hope that it will be added back 🤞 |
Open
Any update on this? Are you accepting PR to restore that behaviour? |
Hey, indeed, Sorry about breaking this behavior, I see the utility of this feature. I would certainly accept a PR to change this back to the old behavior. I just don't have time to do it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @norwoodj
It seems that v1.10.0 introduces a kind of different behavior.
In the past we used something like this:
the new version now introduces this change:
So in the past lines with two
##
were ignored in the rendered README. Is this an intended change?The text was updated successfully, but these errors were encountered: