Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST service date-time parameters don't work (time is not sent out and date is in wrong format) #9

Open
aasaru opened this issue Nov 15, 2022 · 1 comment

Comments

@aasaru
Copy link

aasaru commented Nov 15, 2022

I have a REST web service with date-time header parameter:

        - in: header
          name: If-Modified-Since
          schema:
            type: string
            format: date-time
            example: 2022-10-18T17:32:28+02:00
          required: false

MISP2 UI renders a nice datepicker and a checkbox to enter time:
misp2-date-time-rendered

I set date to "14.11.2022" and time to "16:52" submit the form this what is show in the logs:

This is what is logged and sent out to the service:

Headers :
if-modified-since: 11/14/2022

Expected behaviour would be that date would be in correct format (yyyy-mm-dd) and time would be appended to it like this:

Headers :
if-modified-since: 2022-11-14T16:52:00+02:00

@aasaru aasaru changed the title date-time parameters don't work (time is not sent out and date is in wrong format) REST service date-time parameters don't work (time is not sent out and date is in wrong format) Nov 15, 2022
@raits
Copy link
Contributor

raits commented Nov 16, 2022

Thank you for reporting this problem to us. It does indeed seem that MISP2 doesn't follow the OpenAPI specification when adding the date.

I have created a backlog item in our JIRA to tackle this: https://nordic-institute.atlassian.net/browse/MISPDEV-86

Unfortunately, I can not offer a timeline for when we can introduce this improvement to MISP2 at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants