Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename swiper-solid.js and swiper-react.js to index.js #5863

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Rename swiper-solid.js and swiper-react.js to index.js #5863

merged 2 commits into from
Jul 8, 2022

Conversation

TiagoCavalcante
Copy link
Contributor

@TiagoCavalcante TiagoCavalcante commented Jul 7, 2022

This way the following code is valid:

// With SolidJS
import { Swiper } from "swiper/solid"
// With React
import { Swiper } from "swiper/react"

This way the following code is valid:
```js
// With SolidJS
import { Swiper } from "swiper/solid"
// With React
import { Swiper } from "swiper/react"
```
@TiagoCavalcante
Copy link
Contributor Author

In my last commit, instead of renaming, I created a file that exports everything from swiper-solid, to keep backward compatibility.

@nolimits4web nolimits4web merged commit 6e94701 into nolimits4web:master Jul 8, 2022
@nolimits4web
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants