feat(core): add support to loop with slotted elements #5117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, when we are working with web components and elements that are being introduced via Slot I have detected that the creation of the loop is not working correctly, since it assumes that the children slides are directly mounted on the wrapper node, but in this case the nodes slides are children of the container.
With this change I pretend that the node that I find is the parent node always starting from one of the slides children nodes.
Example:
Inside my webComponent I have the following structure:
my nodes with the swiper-slide class are in my ligthDom when the loop is created it assumes that it has to put the duplicate nodes inside the wrapper, thus eliminating the slot and causing the swiper to stop working.
functional codePen Example all in shadowDom https://codepen.io/davidigza/pen/XWajKmv
CodePen with slotted content and loop this break the node order https://codepen.io/davidigza/pen/rNzMWVv