Disconnect and reconnect the hanging watch-streams #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all outgoing connections have keep-alive enabled. This should prevent watch-streams from hanging without reconnection.
The unproven suspicion is that RST packets issued by API servers are not delivered back to the operator (as a client of the API) if the API servers are behind a load balancer/proxy or maybe NAT.
Without being properly disconnected, Kopf/aiohttp honestly believes that the stream is alive but simply empty -- for minutes or even hours. It is not necessary for short-lived connections (regular GETs), but goes as a side-effect (can be removed if keepalives bring issues).
This was a reoccurring issue reported multiple times: #847 #698 #614 #585 #232 #204 — with a known workaround but no clear and good defaults to fix that "out of the box", so as with no clear understanding of "how" and "why" and "when" this issue happens. Now, there is at least some idea to try (from #847).