From b627d1c7be535b9e525159eabeb76d2afce36e67 Mon Sep 17 00:00:00 2001 From: AztecBot Date: Thu, 1 May 2025 18:20:21 +0000 Subject: [PATCH 1/5] chore: add link to issue --- compiler/noirc_frontend/src/ast/traits.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/noirc_frontend/src/ast/traits.rs b/compiler/noirc_frontend/src/ast/traits.rs index f5c974d1996..3a389d5ef85 100644 --- a/compiler/noirc_frontend/src/ast/traits.rs +++ b/compiler/noirc_frontend/src/ast/traits.rs @@ -133,7 +133,7 @@ impl Display for TypeImpl { } } -// TODO: display where clauses (follow-up issue) +// TODO(https://github.com/noir-lang/noir/issues/8306): display where clauses (follow-up issue) impl Display for NoirTrait { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { let generics = vecmap(&self.generics, |generic| generic.to_string()); From d173a5f657a6d39e63c2ec256036841976db8182 Mon Sep 17 00:00:00 2001 From: AztecBot Date: Thu, 1 May 2025 18:21:52 +0000 Subject: [PATCH 2/5] . --- compiler/noirc_frontend/src/ast/traits.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/noirc_frontend/src/ast/traits.rs b/compiler/noirc_frontend/src/ast/traits.rs index 3a389d5ef85..f601ace8f6c 100644 --- a/compiler/noirc_frontend/src/ast/traits.rs +++ b/compiler/noirc_frontend/src/ast/traits.rs @@ -133,7 +133,7 @@ impl Display for TypeImpl { } } -// TODO(https://github.com/noir-lang/noir/issues/8306): display where clauses (follow-up issue) +// TODO(https://github.com/noir-lang/noir/issues/8306): display where clauses impl Display for NoirTrait { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { let generics = vecmap(&self.generics, |generic| generic.to_string()); From e170316bc920645d8d0197455d41024759893d96 Mon Sep 17 00:00:00 2001 From: "Michael J. Klein" Date: Mon, 5 May 2025 14:41:11 -0400 Subject: [PATCH 3/5] build.rs rebuild TODO --- tooling/debugger/build.rs | 2 +- tooling/nargo_cli/build.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tooling/debugger/build.rs b/tooling/debugger/build.rs index 204957ae987..5df196a2b12 100644 --- a/tooling/debugger/build.rs +++ b/tooling/debugger/build.rs @@ -27,7 +27,7 @@ fn main() { // Rebuild if the tests have changed println!("cargo:rerun-if-changed=tests"); println!("cargo:rerun-if-changed=ignored-tests.txt"); - // TODO: Running the tests changes the timestamps on test_programs files (file lock?). + // TODO(https://github.com/noir-lang/noir/issues/8351): Running the tests changes the timestamps on test_programs files (file lock?). // That has the knock-on effect of then needing to rebuild the tests after running the tests. println!("cargo:rerun-if-changed={}", test_dir.as_os_str().to_str().unwrap()); diff --git a/tooling/nargo_cli/build.rs b/tooling/nargo_cli/build.rs index c4a300e032a..2a9ef1e9bd1 100644 --- a/tooling/nargo_cli/build.rs +++ b/tooling/nargo_cli/build.rs @@ -27,7 +27,7 @@ fn main() { // Rebuild if the tests have changed println!("cargo:rerun-if-changed=tests"); - // TODO: Running the tests changes the timestamps on test_programs files (file lock?). + // TODO(https://github.com/noir-lang/noir/issues/8351): Running the tests changes the timestamps on test_programs files (file lock?). // That has the knock-on effect of then needing to rebuild the tests after running the tests. println!("cargo:rerun-if-changed={}", test_dir.as_os_str().to_str().unwrap()); From 55ca79414bac3f22bdfa440dbbcb86d36b0d3522 Mon Sep 17 00:00:00 2001 From: "Michael J. Klein" Date: Mon, 5 May 2025 14:44:54 -0400 Subject: [PATCH 4/5] test_name regex TODO --- tooling/debugger/build.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tooling/debugger/build.rs b/tooling/debugger/build.rs index 5df196a2b12..40cab3a07b8 100644 --- a/tooling/debugger/build.rs +++ b/tooling/debugger/build.rs @@ -105,7 +105,7 @@ fn generate_test_runner_debugger_tests(test_file: &mut File, test_data_dir: &Pat .flatten() .collect(); for test_name_line in test_names { - // TODO: get test name by regex perhaps? + // TODO(https://github.com/noir-lang/noir/issues/8352): get test name by regex perhaps? let test_name = test_name_line .split("fn ") .collect::>() From 72090381d006fe07ccf4135d1c529cc92647af51 Mon Sep 17 00:00:00 2001 From: Michael Klein Date: Tue, 6 May 2025 15:22:29 -0400 Subject: [PATCH 5/5] remove fixed TODO --- tooling/nargo_cli/build.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/tooling/nargo_cli/build.rs b/tooling/nargo_cli/build.rs index 2a9ef1e9bd1..57650ceb2ef 100644 --- a/tooling/nargo_cli/build.rs +++ b/tooling/nargo_cli/build.rs @@ -27,8 +27,6 @@ fn main() { // Rebuild if the tests have changed println!("cargo:rerun-if-changed=tests"); - // TODO(https://github.com/noir-lang/noir/issues/8351): Running the tests changes the timestamps on test_programs files (file lock?). - // That has the knock-on effect of then needing to rebuild the tests after running the tests. println!("cargo:rerun-if-changed={}", test_dir.as_os_str().to_str().unwrap()); generate_execution_success_tests(&mut test_file, &test_dir);