From 29a2b7083d1e0433c35458424c02bf053d987886 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Fri, 28 Mar 2025 13:38:30 -0300 Subject: [PATCH 01/16] fix: the default type of a numeric generic is not the numeric generic type --- compiler/noirc_frontend/src/hir_def/types.rs | 8 +++++- compiler/noirc_frontend/src/tests.rs | 27 ++++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/compiler/noirc_frontend/src/hir_def/types.rs b/compiler/noirc_frontend/src/hir_def/types.rs index 2a4673e80ec..15b8205931a 100644 --- a/compiler/noirc_frontend/src/hir_def/types.rs +++ b/compiler/noirc_frontend/src/hir_def/types.rs @@ -257,7 +257,13 @@ impl Kind { match self { Kind::IntegerOrField => Some(Type::default_int_or_field_type()), Kind::Integer => Some(Type::default_int_type()), - Kind::Numeric(typ) => Some(*typ.clone()), + Kind::Numeric(_typ) => { + // Even though we have a type here, that type cannot be used as + // the default type of a numeric generic. + // For example, if we have `let N: u32` and we don't know + // what `N` is, we can't assume it's `u32`. + None + } Kind::Any | Kind::Normal => None, } } diff --git a/compiler/noirc_frontend/src/tests.rs b/compiler/noirc_frontend/src/tests.rs index bc173a86a93..92ac2ada887 100644 --- a/compiler/noirc_frontend/src/tests.rs +++ b/compiler/noirc_frontend/src/tests.rs @@ -4302,3 +4302,30 @@ fn cannot_determine_type_of_generic_argument_in_enum_constructor() { let features = vec![UnstableFeature::Enums]; check_monomorphization_error_using_features(src, &features); } + +#[test] +fn cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic() { + let src = r#" + struct Foo { + array: [Field; N], + } + + impl Foo { + fn new() -> Self { + Self { array: [0; N] } + } + } + + fn foo() -> Foo { + Foo::new() + } + + fn main() { + let _ = foo(); + ^^^ Type annotation needed + ~~~ Could not determine the type of the generic argument `N` declared on the function `foo` + } + "#; + let features = vec![UnstableFeature::Enums]; + check_monomorphization_error_using_features(src, &features); +} From 6b67594321e27c62c4149c66c80c53f58ab40bb2 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Fri, 28 Mar 2025 13:41:27 -0300 Subject: [PATCH 02/16] Numeric generic arguments are values, not types --- compiler/noirc_frontend/src/monomorphization/errors.rs | 5 ++++- compiler/noirc_frontend/src/monomorphization/mod.rs | 6 ++++++ compiler/noirc_frontend/src/tests.rs | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/compiler/noirc_frontend/src/monomorphization/errors.rs b/compiler/noirc_frontend/src/monomorphization/errors.rs index 03a93d8fc85..3329a7b342d 100644 --- a/compiler/noirc_frontend/src/monomorphization/errors.rs +++ b/compiler/noirc_frontend/src/monomorphization/errors.rs @@ -23,6 +23,7 @@ pub enum MonomorphizationError { generic_name: String, item_kind: &'static str, item_name: String, + is_numeric: bool, }, InternalError { message: &'static str, @@ -96,10 +97,12 @@ impl From for CustomDiagnostic { generic_name, item_kind, item_name, + is_numeric, } => { let message = "Type annotation needed".into(); + let type_or_value = if *is_numeric { "value" } else { "type" }; let secondary = format!( - "Could not determine the type of the generic argument `{generic_name}` declared on the {item_kind} `{item_name}`" + "Could not determine the {type_or_value} of the generic argument `{generic_name}` declared on the {item_kind} `{item_name}`", ); return CustomDiagnostic::simple_error(message, secondary, *location); } diff --git a/compiler/noirc_frontend/src/monomorphization/mod.rs b/compiler/noirc_frontend/src/monomorphization/mod.rs index 3aa5e2e27f1..2d50c78cc2c 100644 --- a/compiler/noirc_frontend/src/monomorphization/mod.rs +++ b/compiler/noirc_frontend/src/monomorphization/mod.rs @@ -1360,11 +1360,13 @@ impl<'interner> Monomorphizer<'interner> { for generic in &meta.direct_generics { if generic.type_var.id() == id { let item_name = self.interner.definition_name(ident.id).to_string(); + let is_numeric = matches!(generic.type_var.kind(), Kind::Numeric(..)); return Err(MonomorphizationError::NoDefaultTypeInItem { location, generic_name: generic.name.to_string(), item_kind: "function", item_name, + is_numeric, }); } } @@ -1386,11 +1388,13 @@ impl<'interner> Monomorphizer<'interner> { let def = def.borrow(); for generic in &def.generics { if generic.type_var.id() == id { + let is_numeric = matches!(generic.type_var.kind(), Kind::Numeric(..)); return Err(MonomorphizationError::NoDefaultTypeInItem { location, generic_name: generic.name.to_string(), item_kind: "enum", item_name: def.name.to_string(), + is_numeric, }); } } @@ -2411,11 +2415,13 @@ fn check_struct_generic_type( let def = def.borrow(); if let Some(generic) = def.generics.get(index) { + let is_numeric = matches!(generic.type_var.kind(), Kind::Numeric(..)); return Err(MonomorphizationError::NoDefaultTypeInItem { location, generic_name: generic.name.to_string(), item_kind: "struct", item_name: def.name.to_string(), + is_numeric, }); } diff --git a/compiler/noirc_frontend/src/tests.rs b/compiler/noirc_frontend/src/tests.rs index 92ac2ada887..12e7f9f11df 100644 --- a/compiler/noirc_frontend/src/tests.rs +++ b/compiler/noirc_frontend/src/tests.rs @@ -4323,7 +4323,7 @@ fn cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numer fn main() { let _ = foo(); ^^^ Type annotation needed - ~~~ Could not determine the type of the generic argument `N` declared on the function `foo` + ~~~ Could not determine the value of the generic argument `N` declared on the function `foo` } "#; let features = vec![UnstableFeature::Enums]; From 6bad237ab7d9660e0ad539e102bdf28c0156e5dc Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Fri, 28 Mar 2025 13:54:21 -0300 Subject: [PATCH 03/16] Constant without a default type is okay --- compiler/noirc_frontend/src/monomorphization/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/noirc_frontend/src/monomorphization/mod.rs b/compiler/noirc_frontend/src/monomorphization/mod.rs index 2d50c78cc2c..42c413c127e 100644 --- a/compiler/noirc_frontend/src/monomorphization/mod.rs +++ b/compiler/noirc_frontend/src/monomorphization/mod.rs @@ -1419,7 +1419,7 @@ impl<'interner> Monomorphizer<'interner> { | HirType::Error | HirType::Quoted(_) => Ok(()), HirType::Constant(_value, kind) => { - if kind.is_error() || kind.default_type().is_none() { + if kind.is_error() { Err(MonomorphizationError::UnknownConstant { location }) } else { Ok(()) From b4d5771f06432cf5657bb4fced18708c7610c69c Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Fri, 28 Mar 2025 13:54:45 -0300 Subject: [PATCH 04/16] Fix inlay hint type of unbound numeric generic --- tooling/lsp/src/requests/inlay_hint.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tooling/lsp/src/requests/inlay_hint.rs b/tooling/lsp/src/requests/inlay_hint.rs index 37cccb789a2..caff2c8f508 100644 --- a/tooling/lsp/src/requests/inlay_hint.rs +++ b/tooling/lsp/src/requests/inlay_hint.rs @@ -521,10 +521,11 @@ fn push_type_parts(typ: &Type, parts: &mut Vec, files: &File } Type::TypeVariable(binding) => match &*binding.borrow() { TypeBinding::Unbound(_, kind) => match kind { - Kind::Any | Kind::Normal => push_type_variable_parts(binding, parts, files), + Kind::Any | Kind::Normal | Kind::Numeric(..) => { + push_type_variable_parts(binding, parts, files) + } Kind::Integer => push_type_parts(&Type::default_int_type(), parts, files), Kind::IntegerOrField => parts.push(string_part("Field")), - Kind::Numeric(typ) => push_type_parts(typ, parts, files), }, _ => { push_type_variable_parts(binding, parts, files); From cd23b6e1e85e376aad923282ae55877ce8d85dc1 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Fri, 28 Mar 2025 14:02:12 -0300 Subject: [PATCH 05/16] clippy --- tooling/lsp/src/requests/inlay_hint.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tooling/lsp/src/requests/inlay_hint.rs b/tooling/lsp/src/requests/inlay_hint.rs index caff2c8f508..2e2a98c0429 100644 --- a/tooling/lsp/src/requests/inlay_hint.rs +++ b/tooling/lsp/src/requests/inlay_hint.rs @@ -522,7 +522,7 @@ fn push_type_parts(typ: &Type, parts: &mut Vec, files: &File Type::TypeVariable(binding) => match &*binding.borrow() { TypeBinding::Unbound(_, kind) => match kind { Kind::Any | Kind::Normal | Kind::Numeric(..) => { - push_type_variable_parts(binding, parts, files) + push_type_variable_parts(binding, parts, files); } Kind::Integer => push_type_parts(&Type::default_int_type(), parts, files), Kind::IntegerOrField => parts.push(string_part("Field")), From 46f6165ce8acf42eef1c800291d51a95faf25b43 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Wed, 2 Apr 2025 17:58:02 -0300 Subject: [PATCH 06/16] . --- .../cannot_deduce_numeric_generic/stderr.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test_programs/compile_failure/cannot_deduce_numeric_generic/stderr.txt b/test_programs/compile_failure/cannot_deduce_numeric_generic/stderr.txt index 5dc3401eb61..e378fdcbbd7 100644 --- a/test_programs/compile_failure/cannot_deduce_numeric_generic/stderr.txt +++ b/test_programs/compile_failure/cannot_deduce_numeric_generic/stderr.txt @@ -1,8 +1,8 @@ -error: Could not determine array length `_`, encountered error: `Expected a constant, but found `_`` - ┌─ src/main.nr:2:5 +error: Type annotation needed + ┌─ src/main.nr:6:13 │ -2 │ N - │ - +6 │ let _ = foo(); + │ --- Could not determine the value of the generic argument `N` declared on the function `foo` │ -Aborting due to 1 previous error \ No newline at end of file +Aborting due to 1 previous error From d2bae8ab54db06dae5aced6e7a9ce1b3b216b197 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Wed, 2 Apr 2025 18:03:01 -0300 Subject: [PATCH 07/16] Fixes --- compiler/noirc_frontend/src/tests.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/compiler/noirc_frontend/src/tests.rs b/compiler/noirc_frontend/src/tests.rs index 0c918b49461..8f5bcb6b76b 100644 --- a/compiler/noirc_frontend/src/tests.rs +++ b/compiler/noirc_frontend/src/tests.rs @@ -4574,6 +4574,7 @@ fn unconstrained_numeric_generic_in_impl() { check_errors!(src); } +#[named] #[test] fn cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic() { let src = r#" @@ -4598,5 +4599,5 @@ fn cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numer } "#; let features = vec![UnstableFeature::Enums]; - check_monomorphization_error_using_features(src, &features); + check_monomorphization_error_using_features!(src, &features); } From a07e9aafaf18073330081ba6c2077a5d6e43a869 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Thu, 3 Apr 2025 18:32:50 -0300 Subject: [PATCH 08/16] Tests --- .../Nargo.toml | 7 +++++++ .../src/main.nr | 19 +++++++++++++++++++ .../src_hash.txt | 1 + .../stderr.txt | 8 ++++++++ 4 files changed, 35 insertions(+) create mode 100644 test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/Nargo.toml create mode 100644 test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src/main.nr create mode 100644 test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src_hash.txt create mode 100644 test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/stderr.txt diff --git a/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/Nargo.toml b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/Nargo.toml new file mode 100644 index 00000000000..9d863231e98 --- /dev/null +++ b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/Nargo.toml @@ -0,0 +1,7 @@ + + [package] + name = "noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic" + type = "bin" + authors = [""] + + [dependencies] \ No newline at end of file diff --git a/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src/main.nr b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src/main.nr new file mode 100644 index 00000000000..d73d2f2ec95 --- /dev/null +++ b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src/main.nr @@ -0,0 +1,19 @@ + + struct Foo { + array: [Field; N], + } + + impl Foo { + fn new() -> Self { + Self { array: [0; N] } + } + } + + fn foo() -> Foo { + Foo::new() + } + + fn main() { + let _ = foo(); + } + \ No newline at end of file diff --git a/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src_hash.txt b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src_hash.txt new file mode 100644 index 00000000000..accede56629 --- /dev/null +++ b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/src_hash.txt @@ -0,0 +1 @@ +7627233576545093977 \ No newline at end of file diff --git a/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/stderr.txt b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/stderr.txt new file mode 100644 index 00000000000..d2e42585da3 --- /dev/null +++ b/test_programs/compile_failure/noirc_frontend_tests_cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic/stderr.txt @@ -0,0 +1,8 @@ +error: Type annotation needed + ┌─ src/main.nr:17:17 + │ +17 │ let _ = foo(); + │ --- Could not determine the value of the generic argument `N` declared on the function `foo` + │ + +Aborting due to 1 previous error From 2e2234cc9bfc850270b29aafc2fdc6fc7dfb40e5 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Thu, 3 Apr 2025 18:40:48 -0300 Subject: [PATCH 09/16] Bump Aztec-Packages commit --- .github/benchmark_projects.yml | 2 +- EXTERNAL_NOIR_LIBRARIES.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/benchmark_projects.yml b/.github/benchmark_projects.yml index c98ccabb8b6..b500c1dd3cb 100644 --- a/.github/benchmark_projects.yml +++ b/.github/benchmark_projects.yml @@ -1,4 +1,4 @@ -define: &AZ_COMMIT 153a606384da62e817654c3d91253fc019864f06 +define: &AZ_COMMIT 6ad68ed107e8a515557ea57ea9b6f7048d786a1e projects: private-kernel-inner: repo: AztecProtocol/aztec-packages diff --git a/EXTERNAL_NOIR_LIBRARIES.yml b/EXTERNAL_NOIR_LIBRARIES.yml index 294733d55d1..205aed79f23 100644 --- a/EXTERNAL_NOIR_LIBRARIES.yml +++ b/EXTERNAL_NOIR_LIBRARIES.yml @@ -1,4 +1,4 @@ -define: &AZ_COMMIT 153a606384da62e817654c3d91253fc019864f06 +define: &AZ_COMMIT 6ad68ed107e8a515557ea57ea9b6f7048d786a1e libraries: noir_check_shuffle: repo: noir-lang/noir_check_shuffle From d5f4eb79f8119fabe01b45208011a0f7d7214ae5 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Mon, 7 Apr 2025 09:04:37 -0300 Subject: [PATCH 10/16] Fix after merge --- compiler/noirc_frontend/src/monomorphization/mod.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compiler/noirc_frontend/src/monomorphization/mod.rs b/compiler/noirc_frontend/src/monomorphization/mod.rs index c80520864b6..609db9db62e 100644 --- a/compiler/noirc_frontend/src/monomorphization/mod.rs +++ b/compiler/noirc_frontend/src/monomorphization/mod.rs @@ -1379,11 +1379,13 @@ impl<'interner> Monomorphizer<'interner> { let typ = typ.borrow(); let item_name = typ.name.to_string(); let item_kind = if typ.is_struct() { "struct" } else { "enum" }; + let is_numeric = matches!(generic.type_var.kind(), Kind::Numeric(..)); return Err(MonomorphizationError::NoDefaultTypeInItem { location, generic_name: generic.name.to_string(), item_kind, item_name, + is_numeric, }); } } From 8b6ec523d9ca8114c126363ce473ad796dc954b1 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Tue, 13 May 2025 19:54:17 -0300 Subject: [PATCH 11/16] Bump Aztec-Packages commit --- .github/benchmark_projects.yml | 2 +- EXTERNAL_NOIR_LIBRARIES.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/benchmark_projects.yml b/.github/benchmark_projects.yml index e7f0713dd68..61dee6890cc 100644 --- a/.github/benchmark_projects.yml +++ b/.github/benchmark_projects.yml @@ -1,4 +1,4 @@ -define: &AZ_COMMIT b67afe429d431c7516b95f9c6d1b6e358907ef33 +define: &AZ_COMMIT 9f0dcc87221b4ccbe61713a77a52527176bad535 projects: private-kernel-inner: repo: AztecProtocol/aztec-packages diff --git a/EXTERNAL_NOIR_LIBRARIES.yml b/EXTERNAL_NOIR_LIBRARIES.yml index 17f2f6a4819..211c86d398f 100644 --- a/EXTERNAL_NOIR_LIBRARIES.yml +++ b/EXTERNAL_NOIR_LIBRARIES.yml @@ -1,4 +1,4 @@ -define: &AZ_COMMIT b67afe429d431c7516b95f9c6d1b6e358907ef33 +define: &AZ_COMMIT 9f0dcc87221b4ccbe61713a77a52527176bad535 libraries: noir_check_shuffle: repo: noir-lang/noir_check_shuffle From aa8c26c8e2aaaf827c7dbfe45f7f7b03ab0d047c Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Tue, 13 May 2025 20:24:41 -0300 Subject: [PATCH 12/16] Remove duplicate function --- compiler/noirc_frontend/src/tests.rs | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/compiler/noirc_frontend/src/tests.rs b/compiler/noirc_frontend/src/tests.rs index 67ba1fb624c..9498f8bf2e9 100644 --- a/compiler/noirc_frontend/src/tests.rs +++ b/compiler/noirc_frontend/src/tests.rs @@ -4743,31 +4743,3 @@ fn cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numer let features = vec![UnstableFeature::Enums]; check_monomorphization_error_using_features!(src, &features); } - -#[named] -#[test] -fn cannot_determine_type_of_generic_argument_in_function_call_when_it_is_a_numeric_generic() { - let src = r#" - struct Foo { - array: [Field; N], - } - - impl Foo { - fn new() -> Self { - Self { array: [0; N] } - } - } - - fn foo() -> Foo { - Foo::new() - } - - fn main() { - let _ = foo(); - ^^^ Type annotation needed - ~~~ Could not determine the value of the generic argument `N` declared on the function `foo` - } - "#; - let features = vec![UnstableFeature::Enums]; - check_monomorphization_error_using_features!(src, &features); -} From acaa37d7bd4726d158ff791106ea52b1de980b74 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Wed, 14 May 2025 15:10:43 -0300 Subject: [PATCH 13/16] Bump Aztec-Packages commit --- .github/benchmark_projects.yml | 2 +- EXTERNAL_NOIR_LIBRARIES.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/benchmark_projects.yml b/.github/benchmark_projects.yml index 61dee6890cc..4fab3eedd80 100644 --- a/.github/benchmark_projects.yml +++ b/.github/benchmark_projects.yml @@ -1,4 +1,4 @@ -define: &AZ_COMMIT 9f0dcc87221b4ccbe61713a77a52527176bad535 +define: &AZ_COMMIT ed780d06d669ede490c8d8002979c082fd6b3632 projects: private-kernel-inner: repo: AztecProtocol/aztec-packages diff --git a/EXTERNAL_NOIR_LIBRARIES.yml b/EXTERNAL_NOIR_LIBRARIES.yml index 211c86d398f..2c9992aef67 100644 --- a/EXTERNAL_NOIR_LIBRARIES.yml +++ b/EXTERNAL_NOIR_LIBRARIES.yml @@ -1,4 +1,4 @@ -define: &AZ_COMMIT 9f0dcc87221b4ccbe61713a77a52527176bad535 +define: &AZ_COMMIT ed780d06d669ede490c8d8002979c082fd6b3632 libraries: noir_check_shuffle: repo: noir-lang/noir_check_shuffle From cdc8679c8fa4b6a9046e4884fa8dc04dea20dd56 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Wed, 14 May 2025 16:43:53 -0300 Subject: [PATCH 14/16] Remove unused generic in test program --- test_programs/noir_test_success/ski_calculus/src/main.nr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_programs/noir_test_success/ski_calculus/src/main.nr b/test_programs/noir_test_success/ski_calculus/src/main.nr index 44aa2754c28..87ae912e5e7 100644 --- a/test_programs/noir_test_success/ski_calculus/src/main.nr +++ b/test_programs/noir_test_success/ski_calculus/src/main.nr @@ -115,7 +115,7 @@ impl From for ShowState { } impl ShowState { - pub fn step(&mut self) -> Option { + pub fn step(&mut self) -> Option { if self.done { Option::none() } else { From 5776ff1c495fa715cc4bee27042d831d0a622871 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Wed, 21 May 2025 14:47:46 -0300 Subject: [PATCH 15/16] A few libraries don't compile with this change --- .../{.failures.jsonl => .failures.jsonl.does_not_compile} | 0 .../{.failures.jsonl => .failures.jsonl.does_not_compile} | 0 .../{.failures.jsonl => .failures.jsonl.does_not_compile} | 0 3 files changed, 0 insertions(+), 0 deletions(-) rename .github/critical_libraries_status/noir-lang/noir_rsa/{.failures.jsonl => .failures.jsonl.does_not_compile} (100%) rename .github/critical_libraries_status/zkemail/noir-jwt/{.failures.jsonl => .failures.jsonl.does_not_compile} (100%) rename .github/critical_libraries_status/zkpassport/noir_rsa/{.failures.jsonl => .failures.jsonl.does_not_compile} (100%) diff --git a/.github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl b/.github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl.does_not_compile similarity index 100% rename from .github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl rename to .github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl.does_not_compile diff --git a/.github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl b/.github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl.does_not_compile similarity index 100% rename from .github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl rename to .github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl.does_not_compile diff --git a/.github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl b/.github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl.does_not_compile similarity index 100% rename from .github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl rename to .github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl.does_not_compile From eb3381d01e4b0321f69c225d8e8331191438f6f8 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Wed, 21 May 2025 15:12:34 -0300 Subject: [PATCH 16/16] Revert "A few libraries don't compile with this change" This reverts commit 5776ff1c495fa715cc4bee27042d831d0a622871. --- .../{.failures.jsonl.does_not_compile => .failures.jsonl} | 0 .../{.failures.jsonl.does_not_compile => .failures.jsonl} | 0 .../{.failures.jsonl.does_not_compile => .failures.jsonl} | 0 3 files changed, 0 insertions(+), 0 deletions(-) rename .github/critical_libraries_status/noir-lang/noir_rsa/{.failures.jsonl.does_not_compile => .failures.jsonl} (100%) rename .github/critical_libraries_status/zkemail/noir-jwt/{.failures.jsonl.does_not_compile => .failures.jsonl} (100%) rename .github/critical_libraries_status/zkpassport/noir_rsa/{.failures.jsonl.does_not_compile => .failures.jsonl} (100%) diff --git a/.github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl.does_not_compile b/.github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl similarity index 100% rename from .github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl.does_not_compile rename to .github/critical_libraries_status/noir-lang/noir_rsa/.failures.jsonl diff --git a/.github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl.does_not_compile b/.github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl similarity index 100% rename from .github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl.does_not_compile rename to .github/critical_libraries_status/zkemail/noir-jwt/.failures.jsonl diff --git a/.github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl.does_not_compile b/.github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl similarity index 100% rename from .github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl.does_not_compile rename to .github/critical_libraries_status/zkpassport/noir_rsa/.failures.jsonl