From a4d47396444f8b62df078903f600aaa4791fb59c Mon Sep 17 00:00:00 2001 From: Michael Klein Date: Fri, 28 Mar 2025 11:54:17 -0400 Subject: [PATCH 1/2] chore: deduplicate 'double_generic_alias_in_path' --- compiler/noirc_frontend/src/tests/aliases.rs | 16 +++++++++++++++- .../double_generic_alias_in_path/Nargo.toml | 7 ------- .../double_generic_alias_in_path/src/main.nr | 14 -------------- 3 files changed, 15 insertions(+), 22 deletions(-) delete mode 100644 test_programs/compile_success_empty/double_generic_alias_in_path/Nargo.toml delete mode 100644 test_programs/compile_success_empty/double_generic_alias_in_path/src/main.nr diff --git a/compiler/noirc_frontend/src/tests/aliases.rs b/compiler/noirc_frontend/src/tests/aliases.rs index 1a5621c8adb..ddb7f2bef0b 100644 --- a/compiler/noirc_frontend/src/tests/aliases.rs +++ b/compiler/noirc_frontend/src/tests/aliases.rs @@ -72,6 +72,20 @@ fn double_alias_in_path() { #[test] fn double_generic_alias_in_path() { let src = r#" + struct Foo {} + + impl Foo { + fn new() -> Self { + Self {} + } + } + + type FooAlias1 = Foo; + type FooAlias2 = FooAlias1; + + fn main() { + let _ = FooAlias2::new(); + } "#; - assert_no_errors(src); + assert_no_errors!(src); } diff --git a/test_programs/compile_success_empty/double_generic_alias_in_path/Nargo.toml b/test_programs/compile_success_empty/double_generic_alias_in_path/Nargo.toml deleted file mode 100644 index aaebee8d6ef..00000000000 --- a/test_programs/compile_success_empty/double_generic_alias_in_path/Nargo.toml +++ /dev/null @@ -1,7 +0,0 @@ -[package] -name = "double_generic_alias_in_path" -type = "bin" -authors = [""] -compiler_version = ">=0.32.0" - -[dependencies] diff --git a/test_programs/compile_success_empty/double_generic_alias_in_path/src/main.nr b/test_programs/compile_success_empty/double_generic_alias_in_path/src/main.nr deleted file mode 100644 index 09f2e5c4b43..00000000000 --- a/test_programs/compile_success_empty/double_generic_alias_in_path/src/main.nr +++ /dev/null @@ -1,14 +0,0 @@ -struct Foo {} - -impl Foo { - fn new() -> Self { - Self {} - } -} - -type FooAlias1 = Foo; -type FooAlias2 = FooAlias1; - -fn main() { - let _ = FooAlias2::new(); -} From 72687f322dcc6cf67cd2f070f76eddb64d9d8116 Mon Sep 17 00:00:00 2001 From: Michael Klein Date: Fri, 28 Mar 2025 11:56:59 -0400 Subject: [PATCH 2/2] remove ! --- compiler/noirc_frontend/src/tests/aliases.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/noirc_frontend/src/tests/aliases.rs b/compiler/noirc_frontend/src/tests/aliases.rs index ddb7f2bef0b..5c4b8b59a58 100644 --- a/compiler/noirc_frontend/src/tests/aliases.rs +++ b/compiler/noirc_frontend/src/tests/aliases.rs @@ -87,5 +87,5 @@ fn double_generic_alias_in_path() { let _ = FooAlias2::new(); } "#; - assert_no_errors!(src); + assert_no_errors(src); }