diff --git a/compiler/noirc_frontend/src/hir/resolution/import.rs b/compiler/noirc_frontend/src/hir/resolution/import.rs index 16e25b80465..14e0e5e5386 100644 --- a/compiler/noirc_frontend/src/hir/resolution/import.rs +++ b/compiler/noirc_frontend/src/hir/resolution/import.rs @@ -112,7 +112,7 @@ impl<'a> From<&'a PathResolutionError> for CustomDiagnostic { CustomDiagnostic::simple_error(error.to_string(), String::new(), ident.location()) } PathResolutionError::TraitMethodNotInScope { ident, .. } => { - CustomDiagnostic::simple_warning(error.to_string(), String::new(), ident.location()) + CustomDiagnostic::simple_error(error.to_string(), String::new(), ident.location()) } PathResolutionError::UnresolvedWithPossibleTraitsToImport { ident, traits } => { let mut traits = vecmap(traits, |trait_name| format!("`{}`", trait_name)); diff --git a/test_programs/execution_success/derive/src/main.nr b/test_programs/execution_success/derive/src/main.nr index f7d4f6b607a..724c185737b 100644 --- a/test_programs/execution_success/derive/src/main.nr +++ b/test_programs/execution_success/derive/src/main.nr @@ -1,4 +1,4 @@ -use std::hash::Hash; +use std::hash::{Hash, Hasher}; #[derive_via(derive_do_nothing)] trait DoNothing { diff --git a/test_programs/execution_success/embedded_curve_ops/src/main.nr b/test_programs/execution_success/embedded_curve_ops/src/main.nr index 85cf60dc796..dcccdfd16fb 100644 --- a/test_programs/execution_success/embedded_curve_ops/src/main.nr +++ b/test_programs/execution_success/embedded_curve_ops/src/main.nr @@ -1,3 +1,5 @@ +use std::ops::Add; + fn main(priv_key: Field, pub_x: pub Field, pub_y: pub Field) { let g1_y = 17631683881184975370165255887551781615748388533673675138860; let g1 = std::embedded_curve_ops::EmbeddedCurvePoint { x: 1, y: g1_y, is_infinite: false }; diff --git a/test_programs/execution_success/inline_decompose_hint_brillig_call/src/main.nr b/test_programs/execution_success/inline_decompose_hint_brillig_call/src/main.nr index e500f0f976d..a5d57d0596d 100644 --- a/test_programs/execution_success/inline_decompose_hint_brillig_call/src/main.nr +++ b/test_programs/execution_success/inline_decompose_hint_brillig_call/src/main.nr @@ -1,4 +1,7 @@ -use std::embedded_curve_ops::{EmbeddedCurvePoint, EmbeddedCurveScalar, fixed_base_scalar_mul}; +use std::{ + embedded_curve_ops::{EmbeddedCurvePoint, EmbeddedCurveScalar, fixed_base_scalar_mul}, + ops::Add, +}; fn main() -> pub Field { let pre_address = 0x23d95e303879a5d0bbef78ecbc335e559da37431f6dcd11da54ed375c2846813; diff --git a/test_programs/execution_success/traits_in_crates_1/crate1/src/lib.nr b/test_programs/execution_success/traits_in_crates_1/crate1/src/lib.nr index e36a263093a..d472755e1fd 100644 --- a/test_programs/execution_success/traits_in_crates_1/crate1/src/lib.nr +++ b/test_programs/execution_success/traits_in_crates_1/crate1/src/lib.nr @@ -1,4 +1,4 @@ -trait MyTrait { +pub trait MyTrait { fn Add10(&mut self); } diff --git a/test_programs/execution_success/traits_in_crates_1/crate2/src/lib.nr b/test_programs/execution_success/traits_in_crates_1/crate2/src/lib.nr index c59bf0387c1..8f8df053f80 100644 --- a/test_programs/execution_success/traits_in_crates_1/crate2/src/lib.nr +++ b/test_programs/execution_success/traits_in_crates_1/crate2/src/lib.nr @@ -1,3 +1,3 @@ -struct MyStruct { - Q: Field, +pub struct MyStruct { + pub Q: Field, } diff --git a/test_programs/execution_success/traits_in_crates_1/src/main.nr b/test_programs/execution_success/traits_in_crates_1/src/main.nr index 2afec29ee1f..9f2768fc9bf 100644 --- a/test_programs/execution_success/traits_in_crates_1/src/main.nr +++ b/test_programs/execution_success/traits_in_crates_1/src/main.nr @@ -1,3 +1,5 @@ +use crate1::MyTrait; + fn main(x: Field, y: pub Field) { let mut V = crate2::MyStruct { Q: x }; V.Add10(); diff --git a/test_programs/execution_success/traits_in_crates_2/crate1/src/lib.nr b/test_programs/execution_success/traits_in_crates_2/crate1/src/lib.nr index 59a28a50c79..72cac406138 100644 --- a/test_programs/execution_success/traits_in_crates_2/crate1/src/lib.nr +++ b/test_programs/execution_success/traits_in_crates_2/crate1/src/lib.nr @@ -1,3 +1,3 @@ -trait MyTrait { +pub trait MyTrait { fn Add10(&mut self); } diff --git a/test_programs/execution_success/traits_in_crates_2/crate2/src/lib.nr b/test_programs/execution_success/traits_in_crates_2/crate2/src/lib.nr index fe6a94a4a95..e80ff59474f 100644 --- a/test_programs/execution_success/traits_in_crates_2/crate2/src/lib.nr +++ b/test_programs/execution_success/traits_in_crates_2/crate2/src/lib.nr @@ -1,5 +1,5 @@ -struct MyStruct { - Q: Field, +pub struct MyStruct { + pub Q: Field, } impl crate1::MyTrait for MyStruct { diff --git a/test_programs/execution_success/traits_in_crates_2/src/main.nr b/test_programs/execution_success/traits_in_crates_2/src/main.nr index 2afec29ee1f..9f2768fc9bf 100644 --- a/test_programs/execution_success/traits_in_crates_2/src/main.nr +++ b/test_programs/execution_success/traits_in_crates_2/src/main.nr @@ -1,3 +1,5 @@ +use crate1::MyTrait; + fn main(x: Field, y: pub Field) { let mut V = crate2::MyStruct { Q: x }; V.Add10(); diff --git a/tooling/nargo_cli/tests/stdlib-props.rs b/tooling/nargo_cli/tests/stdlib-props.rs index 7c3794d03ab..b00d50c8348 100644 --- a/tooling/nargo_cli/tests/stdlib-props.rs +++ b/tooling/nargo_cli/tests/stdlib-props.rs @@ -177,7 +177,10 @@ fn fuzz_poseidon_equivalence() { // Noir has hashes up to length 16, but the reference library won't work with more than 12. for len in 1..light_poseidon::MAX_X5_LEN { let source = format!( - "fn main(input: [Field; {len}]) -> pub Field {{ + " + use std::hash::{{Hash, Hasher}}; + + fn main(input: [Field; {len}]) -> pub Field {{ let h1 = std::hash::poseidon::bn254::hash_{len}(input); let h2 = {{ let mut hasher = std::hash::poseidon::PoseidonHasher::default();