From f2dcbca78ecae13bb14512574a1e375e8a1b61c2 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Thu, 6 Nov 2025 14:24:25 -0300 Subject: [PATCH] chore: use SignedField::from_signed in enums.rs --- .../noirc_frontend/src/elaborator/enums.rs | 21 ++++--------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/compiler/noirc_frontend/src/elaborator/enums.rs b/compiler/noirc_frontend/src/elaborator/enums.rs index 9dc9bf7a8e3..762c87dc541 100644 --- a/compiler/noirc_frontend/src/elaborator/enums.rs +++ b/compiler/noirc_frontend/src/elaborator/enums.rs @@ -836,26 +836,13 @@ impl Elaborator<'_> { expr_location: location, }); - // Convert a signed integer type like i32 to SignedField - macro_rules! signed_to_signed_field { - ($value:expr) => {{ - let negative = $value < 0; - // Widen the value so that SignedType::MIN does not wrap to 0 when negated below - let mut widened = i128::from($value); - if negative { - widened = -widened; - } - SignedField::new(widened.into(), negative) - }}; - } - let value = match constant { Value::Bool(value) => SignedField::positive(value), Value::Field(value) => value, - Value::I8(value) => signed_to_signed_field!(value), - Value::I16(value) => signed_to_signed_field!(value), - Value::I32(value) => signed_to_signed_field!(value), - Value::I64(value) => signed_to_signed_field!(value), + Value::I8(value) => SignedField::from_signed(value), + Value::I16(value) => SignedField::from_signed(value), + Value::I32(value) => SignedField::from_signed(value), + Value::I64(value) => SignedField::from_signed(value), Value::U1(value) => SignedField::positive(value), Value::U8(value) => SignedField::positive(u128::from(value)), Value::U16(value) => SignedField::positive(u128::from(value)),