From 99b7c9dd39a82af3a01fc30cb6837dd0c89236bc Mon Sep 17 00:00:00 2001 From: guipublic Date: Fri, 1 Aug 2025 16:55:03 +0200 Subject: [PATCH 1/2] switch to new bit shifts semantic --- src/fns/unconstrained_helpers.nr | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/fns/unconstrained_helpers.nr b/src/fns/unconstrained_helpers.nr index 788f8176..525fcabe 100644 --- a/src/fns/unconstrained_helpers.nr +++ b/src/fns/unconstrained_helpers.nr @@ -366,10 +366,10 @@ pub(crate) unconstrained fn __shr(input: [u128; N], shift: u32) -> [ let mut result: [u128; N] = [0; N]; let num_shifted_limbs = shift / 120; - let limb_shift = (shift % 120) as u8; - let remainder_shift = (120 - limb_shift) as u8; + let limb_shift = (shift % 120) as u128; + let remainder_shift = (120 - limb_shift); let mask: u128 = (((1 as u128) << limb_shift) - 1) << remainder_shift; - result[0] = (input[0 + num_shifted_limbs] >> limb_shift); + result[0] = (input[0 + num_shifted_limbs] >> (limb_shift)); for i in 1..(N - num_shifted_limbs) { let value = input[i + num_shifted_limbs]; result[i] = value >> limb_shift; @@ -383,8 +383,8 @@ pub(crate) unconstrained fn __shl(input: [u128; N], shift: u32) -> [ let mut result: [u128; N] = [0; N]; let num_shifted_limbs = shift / 120; - let limb_shift = (shift % 120) as u8; - let remainder_shift: u8 = 120 - limb_shift as u8; + let limb_shift = (shift % 120) as u128; + let remainder_shift = 120 - limb_shift; // 83 // limb shift = 1 @@ -460,9 +460,9 @@ pub(crate) unconstrained fn __get_msb(val: [u128; N]) -> u32 { pub(crate) fn __get_bit(input: [u128; N], bit: u32) -> bool { let segment_index: u32 = bit / 120; - let uint_index = bit % 120; + let uint_index = (bit % 120) as u128; let limb: u128 = input[segment_index]; - let value = (limb >> uint_index as u8) & 1; + let value = (limb >> uint_index) & 1; value == 1 } From cb935a3d4dd3e276f404279d6153ed1670966f23 Mon Sep 17 00:00:00 2001 From: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Thu, 14 Aug 2025 17:27:14 +0000 Subject: [PATCH 2/2] . --- .github/workflows/benchmark.yml | 4 ++-- .github/workflows/test.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 3c6748be..7ef47799 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -17,12 +17,12 @@ jobs: - name: Install Nargo uses: noir-lang/noirup@v0.1.4 with: - toolchain: 1.0.0-beta.7 + toolchain: nightly-2025-08-15 - name: Install bb run: | curl -L https://bbup.aztec.network | bash - ~/.bb/bbup -nv 1.0.0-beta.7 + ~/.bb/bbup -nv 1.0.0-beta.9 sudo apt install libc++-dev - name: Build Noir benchmark programs diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1ece6a99..ebde9220 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ on: env: CARGO_TERM_COLOR: always - MINIMUM_NOIR_VERSION: v1.0.0-beta.7 + MINIMUM_NOIR_VERSION: nightly-2025-08-15 jobs: noir-version-list: