Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql/batch should end response and not pass execution to next callback #13

Closed
genbit opened this issue Aug 2, 2016 · 2 comments
Closed

Comments

@genbit
Copy link

genbit commented Aug 2, 2016

Hi,

I found in the code, that after processing graphql batch, express middleware will just call next();

https://github.com/nodkz/react-relay-network-layer/blob/master/src/express-middleware/graphqlBatchHTTPWrapper.js#L43

It causes request to be processed again by standard graphql middleware, which leads to an error.

@nodkz
Copy link
Collaborator

nodkz commented Aug 2, 2016

Thanks!

I'll fix it in 2 days. I have a small vacation right now and answer from mobile to you.

@nodkz
Copy link
Collaborator

nodkz commented Aug 5, 2016

Fixed in 1.3.3

@nodkz nodkz closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants