Skip to content

deps: update json to 3.12.0 #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

deps: update json to 3.12.0 #308

wants to merge 1 commit into from

Conversation

@santigimeno
Copy link
Member

@santigimeno santigimeno commented May 7, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Updated license year for a bundled dependency.
    • Updated version information and copyright years for a bundled dependency.

  • New Features

    • Added support for a new diagnostic positions macro in the bundled JSON library, enhancing diagnostic capabilities.

@santigimeno santigimeno self-assigned this May 7, 2025
@windsurf-bot
Copy link

windsurf-bot bot commented May 7, 2025

The total size of the files in this PR is too large.

@coderabbitai
Copy link

coderabbitai bot commented May 7, 2025 •
edited
Loading

Walkthrough

The changes update the copyright year in the MIT license for the deps/json dependency and revise versioning and macro definitions in the json_fwd.hpp header. The header now reflects version 3.12.0, introduces a new macro for diagnostic positions, and updates ABI tag macros to accommodate this addition.

Changes

File(s) Change Summary
deps/json/LICENSE.MIT Updated copyright year from 2022 to 2025.
deps/json/single_include/nlohmann/json_fwd.hpp Updated version macros to 3.12.0 and copyright years to 2025; added JSON_DIAGNOSTIC_POSITIONS macro and related ABI tag concatenation logic.

Poem

In the warren, code anew,
A license year hops into view.
Macros multiply, tags align,
Version numbers freshly shine.
Diagnostic trails now in sight,
JSON’s future looking bright!
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4cec8cd and aca6c02.

📒 Files selected for processing (2)
  • deps/json/LICENSE.MIT (1 hunks)
  • deps/json/single_include/nlohmann/json_fwd.hpp (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • deps/json/LICENSE.MIT
  • deps/json/single_include/nlohmann/json_fwd.hpp
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: test-tarball-linux
  • GitHub Check: test-linux (ubuntu-24.04-arm)
  • GitHub Check: test-linux (ubuntu-24.04)
  • GitHub Check: test-macOS
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 7, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
deps/json/single_include/nlohmann/json_fwd.hpp (1)

47-49: Introduce JSON_DIAGNOSTIC_POSITIONS macro
A new JSON_DIAGNOSTIC_POSITIONS macro defaults to 0 when undefined.

Consider updating the library documentation or README to explain how to enable this feature via -DJSON_DIAGNOSTIC_POSITIONS=1.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9265d2f and 4cec8cd.

📒 Files selected for processing (2)
  • deps/json/LICENSE.MIT (1 hunks)
  • deps/json/single_include/nlohmann/json_fwd.hpp (5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: lint-js-and-md
  • GitHub Check: test-linux (ubuntu-24.04-arm)
  • GitHub Check: test-linux (ubuntu-24.04)
  • GitHub Check: test-macOS
  • GitHub Check: build-tarball
🔇 Additional comments (7)
deps/json/LICENSE.MIT (1)

3-3: License year updated appropriately
The copyright year has been updated to 2025 to reflect the new release.

deps/json/single_include/nlohmann/json_fwd.hpp (6)

3-6: Bump ASCII-art banner and SPDX dates
The version in the ASCII-art header and the SPDX-FileCopyrightText have been updated to 3.12.0 and 2025 respectively. This aligns with the new release.

Also applies to: 21-24

33-33: Update library‐version check
The #warning guard now correctly compares against 3.12.0.

40-41: Set version macros to 3.12.0
The NLOHMANN_JSON_VERSION_MINOR and NLOHMANN_JSON_VERSION_PATCH macros have been bumped to 12 and 0.

61-65: Add ABI tag for diagnostic positions
The NLOHMANN_JSON_ABI_TAG_DIAGNOSTIC_POSITIONS macro correctly expands to _dp when enabled, complementing existing ABI tags.

78-80: Extend ABI‐tag concatenation macros
The _CONCAT_EX and _CONCAT macros now accept three components, accommodating the new diagnostic-positions tag.

84-85: Update ABI-tags invocation
The NLOHMANN_JSON_ABI_TAGS macro now concatenates diagnostics, legacy comparison, and diagnostic-positions tags, ensuring the inline namespace reflects all ABI variants.

@santigimeno santigimeno force-pushed the santi/update_nlohmann_json branch from 4cec8cd to aca6c02 Compare May 12, 2025 14:12
santigimeno added a commit that referenced this pull request Jun 5, 2025
@santigimeno
deps: update json to 3.12.0
dcb7e63 
PR-URL: #308
Reviewed-By: Rafael Gonzaga <[email protected]>
@santigimeno
Copy link
Member Author

santigimeno commented Jun 5, 2025

Landed in dcb7e63

@santigimeno santigimeno closed this Jun 5, 2025
@santigimeno santigimeno deleted the santi/update_nlohmann_json branch June 5, 2025 13:32
santigimeno added a commit that referenced this pull request Aug 25, 2025
@santigimeno
deps: update json to 3.12.0
612194b 
PR-URL: #308
Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno added a commit that referenced this pull request Aug 26, 2025
@santigimeno
deps: update json to 3.12.0
b3afa67 
PR-URL: #308
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #359
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@santigimeno santigimeno

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@santigimeno @RafaelGSS