Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeschool/montreal to Netlify for CD system #490

Closed
matchai opened this issue Nov 8, 2017 · 7 comments
Closed

Add nodeschool/montreal to Netlify for CD system #490

matchai opened this issue Nov 8, 2017 · 7 comments

Comments

@matchai
Copy link

matchai commented Nov 8, 2017

Howdy Nodeschol! 🤠

Over at nodeschool/montreal we're implementing i18n to give equal opportunity to our English and French students. Because our jekyll stack will need some fancier plugins to get the job done, we found the easiest solution would be to hook the app up to Netlify to build and host our jekyll site.

Unfortunately, I don't have the rights to add Netlify as a GitHub integration to nodeschool/montreal. If someone can get the necessary wiring done on the Netlify side of things, or grant me the appropriate rights, that would be much appreciated! 😄

@riyadhalnur
Copy link
Member

riyadhalnur commented Nov 8, 2017

Hi there @matchai, you have admin access to the Montreal repo already. AFAIK, enabling netlify access would grant them access to all repos in the Nodeschool org. If possible, you can maybe add the webhook and deploy key manually to the Montreal repo itself or I can add it for you if you give them to me.

@matchai
Copy link
Author

matchai commented Nov 8, 2017

It looks like their docs suggest enabling the "Restrict third-party application access", if adding Netlify to an org's repo:
https://www.netlify.com/docs/github-permissions/#restrict-access-for-organizations

When attempting to grant access, at the moment I get this:
image

Unfortunately I don't have access to any webhooks or deploy keys before completing the repo-selection flow.

Thank you for the help, Riyadh!

@riyadhalnur
Copy link
Member

riyadhalnur commented Nov 8, 2017

Ah ok. Maybe you can add me to the team on Netlify and I can set up the pipeline. Would that work?

@matchai
Copy link
Author

matchai commented Nov 8, 2017

Unfortunately I can't create a team on the free tier.

image

I believe that in open-source projects, you can add unlimited contributors to a site, but you can't create a team for them.

Would you be able to create the site on Netlify?

@ajmas
Copy link

ajmas commented Nov 8, 2017

Travis and Circle CI have worked for me. For hosting we could use GitHub, by having the generated results put into a specific branch of the GitHub repo? Remember any branch can be set as the one used for gh-pages and it can just be static HTML files.

We use Travis to deploy to Heroku, for the https://github.com/maison-notman-house/notman-api-server project, though Travis can do anything you want. Circle CI was used for another project, since they allowed free builds for closed source, with certain restrictions.

I'll look at a per repo configuration.

@RichardLitt
Copy link
Member

We could always ask Netlify to help us out here, too. @matchai Have you tried contacting them, mentioning that you're trying to get this working for NodeSchool?

@matchai
Copy link
Author

matchai commented Nov 23, 2017

Looks like we've gotten our CI wired up on Jenkins instead of Netlify with this ticket:
nodeschool/montreal#66

Cheers 👍

@matchai matchai closed this as completed Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants