-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodeschool module menus are still not working with node version 5.6.0 #1641
Comments
@anvis2000 Thank you for reporting it! It would be very helpful to know your system specification (windows? mac? npm version?) and the menu that you try to run. ( |
Actually its the git-it module. I am running Windows 10. Thank you. The menus are non-functional on both my commandline and the Git Shell. |
@anvis2000 Does learnyounode work? |
learnyounode has the same issue with non-functional menus as well. To be more accurate it seems it works sometimes but most of the time it does not. |
What is the windows terminal software that you use? (Preferably with version) |
I've tried both the Windows commandline [version 10.0.10420] and Git Shell git version 2.5.3.windows.1. Neither one works. |
@rvagg this seems to be a node-core regression?! |
Can we get anyone else to confirm on Windows 10? I don't recall seeing any concerns come up on nodejs/node about this so it's possible this is machine-specific somehow. |
Will try. |
From memory I think the previous bug had something to do with character widths didn't it @martinheidegger or am I getting them mixed up? What language is your computer set to @anvis2000? |
And nodejs/node#3490 |
@rvagg The character width has been a separate issue. |
OK, both 5.1.0 and 5.6.0 on windows 10 are working alright for me (with learnyounode). Will try git-it |
git-it works too. Rules out core regression. |
@anvis2000 Could you run |
Just to add to the thread, I'm also seeing the same issue with the git-it workshop + node 5.6.0 + x64Win10. Both PowerShell and standard CMD reproduce the problem. I also noticed the same problem with javascripting, promise-it-wont-hurt, regex-adventure, scope-chains-closures, stream-adventure, and test-anything. I'm not seeing it with the learnyounode or async-you workshops. Everything worked fine when I had Node 5.4.0.
|
Same here. I get a node -p -e "Boolean(process.stdout.isTTY)" = true on both the command line window as well as the Git Shell. |
I think I've gotten to the bottom of this. It seems that the problem with the non-responsive menus only occurs when I have an instance of the Microsoft Edge browser running. When I kill all instances of Edge, the tutorial menus do work. |
I don't use Edge, but tried it out to see if it affects the behavior and didn't see any difference on my Win10 machine. The test code mentioned in nodejs/node#5384 has an 80% failure rate on my machine (48/60 times tried) with and without Edge running. |
I've encountered with the same problem as you, guys, do.. The menu doesn't work even after restarting the shell. It seems pointless, but I've changed the language of the workshop to italiano and I cant't read it obviously. So does anyone know how to fix it? I've been trying only learnyounode so far. Thank you! |
@johnytech do To use the workshop without a functional menu, do
|
I can confirm that menu is not functional on Win 10, node v5.8.0 and v5.10.1, but it does work on node v4.4.5. Have only tried javascripting for now. Edit: Works on node v6.2.0 |
this appears to also be an issue using the ubuntu for windows 10 bash and node v6.4.0 I also ran |
I see from previous threads that there was a problem with workshopper menus being non-functional in node version 4.0.0 and that the issue had been fixed in version 5.1.0. I am currently running node version 5.6.0 and I still have the issue with non-functional menus.
The text was updated successfully, but these errors were encountered: