-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Deprecation warning of the punycode module #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Any news on this? |
No plans to change anything for now. Nodemailer, for various reasons, has no userland dependencies, and it is fully self-contained. Creating a punycode encoder for Nodemailer so that it would work with these very old Node versions (Nodemailer supports all Node.js versions from v6.0.0) is not a priority for now. At least not until Node 22 is released. |
If you don't want the dependency just copy punycode.js into your source base. (License MIT) I guess the node team made it clear, they are not maintaining it anymore, so no loss the from coping the .js instead of depending on it.. They just left it for now for backward compatibility. PS: At least already now the warning message is annoying. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Commenting so this issue isn't closed. |
Observe the identical solution using a custom automated script. #1599 |
It's going to be removed from node core at some point, so probably best to actually correct this issue by depending on punycode.js - as advised from node core for this |
Fixed in latest version |
Same issue. Fixed after updating to v20.11.1, deleting package-lock.json, node_modules and reinstalling
|
Oops, sorry, my bad, it was mongoose's fault. It is working as expected now! |
Latest nodemailer does not use the punycode module anymore, so the warning is coming from somewhere else. |
I was getting this annoying warning, I updated yarn to version 4.1.1, |
Node 21.1 deprecated
punycode
The new documentation suggests:
The text was updated successfully, but these errors were encountered: