Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uvwasi_path_symlink() is broken #71

Closed
cjihrig opened this issue Jan 8, 2020 · 2 comments
Closed

uvwasi_path_symlink() is broken #71

cjihrig opened this issue Jan 8, 2020 · 2 comments

Comments

@cjihrig
Copy link
Collaborator

cjihrig commented Jan 8, 2020 •
edited
Loading

Currently, uvwasi_path_symlink() does not resolve old_path to fd. This is a bug. It should be resolved to fd the same way new_path is.

EDIT: old_path should not be resolved to fd. That said, path_symlink() is broken.
EDIT: uvwasi_path_open() needs to handle opening symlinks created by WASI.
@cjihrig cjihrig changed the title uvwasi_path_symlink() should resolve old_path to fd uvwasi_path_symlink() is broken Jan 9, 2020
@cjihrig
Copy link
Collaborator Author

cjihrig commented Jan 12, 2020

Once #73 lands, this should be resolved on non-Windows platforms.

@cjihrig
Copy link
Collaborator Author

cjihrig commented Jan 20, 2020

Based on nodejs/node#31403 landing in Node, I believe this can be closed.

@cjihrig cjihrig closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjihrig