Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing function uv_fs_lutime #213

Closed
phated opened this issue Jun 26, 2023 · 3 comments
Closed

Missing function uv_fs_lutime #213

phated opened this issue Jun 26, 2023 · 3 comments

Comments

@phated
Copy link
Contributor

phated commented Jun 26, 2023

As reported at bytecodealliance/wasm-micro-runtime#1861 (comment), when compiling uvwasi against the libuv available in Ubuntu-20.04, an error occurs:

product-mini/platforms/linux/build/_deps/uvwasi-src/src/uvwasi.c:1743:7: warning: implicit declaration of function ‘uv_fs_lutime’; did you mean ‘uv_fs_futime’? [-Wimplicit-function-declaration]
 1743 |   r = uv_fs_lutime(NULL, &req, resolved_path, atim, mtim, NULL);
[ 98%] Linking C executable iwasm
/usr/local/bin/ld: _deps/uvwasi-build/libuvwasi_a.a(uvwasi.c.o): in function `uvwasi_path_filestat_set_times':
uvwasi.c:(.text+0x293f): undefined reference to `uv_fs_lutime'

What is the difference between uv_fs_lutime and uv_fs_futime? When was uv_fs_lutime added?

@cjihrig
Copy link
Collaborator

cjihrig commented Jun 26, 2023

When was uv_fs_lutime added?

It was added in v1.36.0 in April of 2020.

What is the difference between uv_fs_lutime and uv_fs_futime?

utime changes the access and modification times of a file based on it's filename. futime does the same thing, except it uses a file descriptor instead of a path. lutime is the same as utime, but does not follow symlinks.

@phated
Copy link
Contributor Author

phated commented Jul 3, 2023

This seems like it might just be an outdated version of libuv being shipped with ubuntu-20.04 then.

@cjihrig
Copy link
Collaborator

cjihrig commented Jul 3, 2023

Agreed. Can this be closed?

@phated phated closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants