-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js uvwasi team Meeting 2023-05-10 #206
Comments
I'm out at OpenJS World/Open Source summit this week. @cjihrig not sure if you are at the conference as well. If not could you chair/lead the meeting this week? |
I'm not at the conference but have a separate conflict with the meeting. I suggest we cancel this week and have any necessary discussion on this issue or the relevant issue from the agenda. |
I'm in favor of cancelling this. I have a lot going on tomorrow |
I'm fine with canceling but I did have an update (and request for help!): in order to start checking uvwasi against the wasi-testsuite, I built a
@cjihrig, are you at all interested in helping me work through some of those issues? I'm on Zulip if you want to discuss asynchronously. |
I largely stopped following WASI development a while ago, so I apologize if I'm missing something obvious. Why are you building a custom binary? Couldn't you test the WASI behavior of Node.js, wasm3, or one of the other projects that supports embedding uvwasi? Is there some other end goal for this custom binary besides running the WASI test suite? If not, it seems like a lot of work for not much return. |
FWIW I got some of the way to imlementing this in wabt. i.e. I think it would be great if we could build something generic that would work with any libwasm.so (i.e. anything that implements the wasm C API such as wasm-interp or libwee8). The generic thing would then work with any wasm runtime.
|
It wasn't a terrible amount of work (or code) given that I could reuse
I mean, if we're just talking about testsuite compliance, though, maybe I should just try that. @sbc100, where should I look to run that?
I agree. As I understand it, #199 is headed towards that and, if implemented, each engine could just link to that to get a WASI implementation. |
king, I am relatively confident I could wire it in with Sightglass... and of course run the wasi-testsuite.
I think I was a long way from being spec compliant. The code IIRC is here: https://github.com/WebAssembly/wabt/blob/7ff04217d72d5c9528c9f167913c52f083ef1948/src/tools/wasm-interp.cc#L341 |
Meeting passed, believe it was cancelled. Closing. |
Time
UTC Wed 10-May-2023 18:00 (06:00 PM):
Or in your local time:
Links
Agenda
Extracted from uvwasi-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/node
fd_readdir
ignorescookie
argument #47193nodejs/uvwasi
Invited
Observers/Guests
Notes
The agenda comes from issues labelled with
uvwasi-agenda
across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.Joining the meeting
The text was updated successfully, but these errors were encountered: