Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/redirect-request.js is flaky #2259

Closed
KhafraDev opened this issue Sep 8, 2023 · 5 comments
Closed

test/redirect-request.js is flaky #2259

KhafraDev opened this issue Sep 8, 2023 · 5 comments

Comments

@KhafraDev
Copy link
Member

its flaky on every version of node and every os in the ci. not sure what test is failing exactly
@metcoder95 metcoder95 mentioned this issue Sep 15, 2023
Merged
7 tasks
@metcoder95
Copy link
Member

🤞 #2265 fixes it

@KhafraDev
Copy link
Member Author

I will close once I see a few more CIs

@KhafraDev
Copy link
Member Author

https://github.com/nodejs/undici/actions/runs/6229473169/job/16908037511?pr=2272#step:14:10764 it's still happening

@metcoder95
Copy link
Member

Dragging comment here about how we can isolate the flaky test issue: #2263 (comment)

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 12, 2024

I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @Uzlopak @metcoder95 @KhafraDev