Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch test fails #1862

Closed
ronag opened this issue Jan 18, 2023 · 2 comments
Closed

fetch test fails #1862

ronag opened this issue Jan 18, 2023 · 2 comments
Labels
bug Something isn't working fetch

Comments

@ronag
Copy link
Member

ronag commented Jan 18, 2023

 FAIL ​ test/fetch/abort.js
 ✖ expect rejected Promise

  t.test('Using AbortSignal.timeout', async (t) => {
    await t.rejects(
------------^
      fetch(`http://localhost:${server.address().port}`, {
        signal: AbortSignal.timeout(50)

  test: test/fetch/abort.js allows aborting with custom errors Using
    AbortSignal.timeout
  at:
    line: 101
    column: 13
    file: test/fetch/abort.js
    type: Test
  found: {}
undici$ node --version
v18.11.0
@ronag ronag added bug Something isn't working fetch labels Jan 18, 2023
@ronag
Copy link
Member Author

ronag commented Jan 18, 2023

@KhafraDev, this is currently blocking making a new release. Should we just disable the test or would you like to dig into it?

@KhafraDev
Copy link
Member

KhafraDev commented Jan 18, 2023

We should disable it, all of the abort tests are flaky on windows. It started happening with a new v18 release but I never bothered to dig into it. I doubt I could figure out the issue regardless if I'm being honest lol.

I don't think there is anything we could do regarding that test unless anyone knows why it's currently flaky:

const server = createServer((req, res) => {
    setTimeout(() => res.end(), 5000)
}).listen(0)

fetch(`http://localhost:${server.address().port}`, {
    signal: AbortSignal.timeout(50)
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fetch
Projects
None yet
Development

No branches or pull requests

3 participants