Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI environment #5

Open
mcollina opened this issue Jun 27, 2017 · 12 comments
Open

Setup CI environment #5

mcollina opened this issue Jun 27, 2017 · 12 comments

Comments

@mcollina
Copy link
Member

mcollina commented Jun 27, 2017

We would to run this on multiple Node.js environments, from 0.8 to 8.

cc @nodejs/build

@mcollina
Copy link
Member Author

@nodejs/build I just need someone to set up the webhook for Travis I don't have access to the secrets.

@rvagg
Copy link
Member

rvagg commented Mar 1, 2018

@joyeecheung I think you did the most recent travis integration, can you give us some hints? I can't do this off the top of my head.

@phillipj
Copy link
Member

phillipj commented Mar 1, 2018

Linking with nodejs/github-bot#166 for future ref.

@mcollina
Copy link
Member Author

mcollina commented Mar 1, 2018

The bot is configured properly, but Travis is not picking it up.

@mcollina
Copy link
Member Author

mcollina commented Mar 5, 2018

Alternatively, can someone from @nodejs/build set up a CI environement identical to the one of readable-stream?

@rvagg
Copy link
Member

rvagg commented Mar 5, 2018

https://ci.nodejs.org/job/string_decoder-continuous-integration/ is this OK? You'll need a ci script of course.

@mcollina
Copy link
Member Author

mcollina commented Mar 5, 2018

@rvagg seems something is not working as expected, https://ci.nodejs.org/job/string_decoder-continuous-integration/MACHINE=debian8-64/3/ is picking up all versions not just one

@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

@rvagg seems something is not working as expected, ci.nodejs.org/job/string_decoder-continuous-integration/MACHINE=debian8-64/3 is picking up all versions not just one

The way I've ended up doing it previously is having a pipeline that triggers the continuous-integration job for each NODE_VERSION.

@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

Which is what was done for readable-stream it seems.

@mcollina does this work? https://ci.nodejs.org/view/All/job/string_decoder-pipeline/

@mcollina
Copy link
Member Author

mcollina commented Mar 5, 2018

Yes, my code is broken :D.

@rvagg
Copy link
Member

rvagg commented Mar 6, 2018

broken on v0.10 and v0.12, are we still supporting those with readable-stream and friends?

@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

Yes, the code should work, I need fo finish the regexps porting from readable-stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants