-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign suggests all versions of Node.js include corepack #6441
Comments
There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version. |
Apparently not. @richardlau, when was Corepack introduced? We can make an if statement to not render this to versions it is known for not being supported. Or should we remove the mention from corepack in the meanwhile until the TSC has an agreement on whether we should or should not have it there? Cc @nodejs/tsc |
According to the links from nodejs/node#39608 16.9.0 and 14.9.0. It's not available in any version of Node.js 13.x and below. |
Thats my preference as well. |
cc @nodejs/nodejs-website feel free to make a PR (or @ruyadorno) cc @nodejs/tsc for awareness. |
I've removed the Corepack mention for the time being, until the TSC decides the future of Corepack. |
URL:
https://nodejs-org-git-meta-remove-legacy-website-code-openjs.vercel.app/en/download
Browser Name:
Firefox
Browser Version:
115.8.0
Operating System:
Windows 11
How to reproduce the issue:
In the redesign it looks like the download page unconditionally includes the string "and corepack":
nodejs.org/pages/en/download/package-manager/current.mdx
Line 14 in 0e15186
This means the string is always present, even if you select a really old version of Node.js e.g. v8.17.0.
AFAIK there is currently no quick way of determining if an arbitrary release of Node.js includes corepack short of looking at the source for the version or unpacking one of the archives. Corepack is not indexed in
index.json
/index.tab
and is unlikely to be while it is experimental.The text was updated successfully, but these errors were encountered: