Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign suggests all versions of Node.js include corepack #6441

Closed
richardlau opened this issue Mar 5, 2024 · 8 comments
Closed

Redesign suggests all versions of Node.js include corepack #6441

richardlau opened this issue Mar 5, 2024 · 8 comments
Labels
bug tsc-agenda website redesign Issue/PR part of the Node.js Website Redesign

Comments

@richardlau
Copy link
Member

URL:

https://nodejs-org-git-meta-remove-legacy-website-code-openjs.vercel.app/en/download

Browser Name:

Firefox

Browser Version:

115.8.0

Operating System:

Windows 11

How to reproduce the issue:

In the redesign it looks like the download page unconditionally includes the string "and corepack":

Node.js includes <LinkWithArrow href="https://npmjs.com">npm</LinkWithArrow> (<Release.NpmVersion />) and corepack.

This means the string is always present, even if you select a really old version of Node.js e.g. v8.17.0.

AFAIK there is currently no quick way of determining if an arbitrary release of Node.js includes corepack short of looking at the source for the version or unpacking one of the archives. Corepack is not indexed in index.json/index.tab and is unlikely to be while it is experimental.

@richardlau richardlau added the bug label Mar 5, 2024
@richardlau
Copy link
Member Author

image

@AugustinMauroy
Copy link
Contributor

There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

@ovflowd
Copy link
Member

ovflowd commented Mar 5, 2024

There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

Apparently not. @richardlau, when was Corepack introduced? We can make an if statement to not render this to versions it is known for not being supported. Or should we remove the mention from corepack in the meanwhile until the TSC has an agreement on whether we should or should not have it there? Cc @nodejs/tsc

@ovflowd ovflowd added tsc-agenda website redesign Issue/PR part of the Node.js Website Redesign labels Mar 5, 2024
@richardlau
Copy link
Member Author

There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

Apparently not. @richardlau, when was Corepack introduced? We can make an if statement to not render this to versions it is known for not being supported. Or should we remove the mention from corepack in the meanwhile until the TSC has an agreement on whether we should or should not have it there? Cc @nodejs/tsc

According to the links from nodejs/node#39608 16.9.0 and 14.9.0. It's not available in any version of Node.js 13.x and below.
I'd prefer not to mention it until its future is decided. The pre-redesign website doesn't mention it.

@mhdawson
Copy link
Member

mhdawson commented Mar 8, 2024

I'd prefer not to mention it until its future is decided

Thats my preference as well.

@ovflowd
Copy link
Member

ovflowd commented Mar 8, 2024

cc @nodejs/nodejs-website feel free to make a PR (or @ruyadorno) cc @nodejs/tsc for awareness.

@ruyadorno
Copy link
Member

Sorry I was OOO this week and I could not follow up with the conversation on #6396. @ovflowd feel free to either reopen that PR or open a new one please. 😊

@ovflowd
Copy link
Member

ovflowd commented Apr 2, 2024

I've removed the Corepack mention for the time being, until the TSC decides the future of Corepack.

@ovflowd ovflowd closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tsc-agenda website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

No branches or pull requests

5 participants